Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change predefined norms to "IEC 60617" + "IEEE 315" #455

Merged
merged 2 commits into from May 25, 2019

Conversation

@ubruhin
Copy link
Member

commented May 24, 2019

See discussion here: https://librepcb.discourse.group/t/how-do-i-add-ieee-315-to-my-preferences/88

I'm not completely happy with this solution, but it's for sure better than the current situation. IEC 60617 and IEEE 315 are the only two norms used in our official libraries so far, thus I think it makes sense to have these norms as suggestions in the workspace/project settings dialogs.

I also updated the component symbol variant editor dialog to use a combobox instead of a text field for specifying the norm, this way it should be more intuitive and easier to choose a norm.

@ubruhin ubruhin added this to the 0.1.2 milestone May 24, 2019

@ubruhin ubruhin self-assigned this May 24, 2019

@dbrgn

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Yeah, I think this makes sense. 👍

@ubruhin ubruhin added this to In Progress in Improve user experience of GUI May 25, 2019

@ubruhin ubruhin merged commit efbdf27 into master May 25, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ubruhin ubruhin deleted the change-predefined-norms branch May 25, 2019

@ubruhin ubruhin moved this from In Progress to Done in Improve user experience of GUI May 25, 2019

ubruhin added a commit that referenced this pull request Jul 8, 2019

Merge pull request #455 from LibrePCB/change-predefined-norms
Change predefined norms to "IEC 60617" + "IEEE 315"
(cherry picked from commit efbdf27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.