Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoardEditor: Fix unintended tool change after double click on footprint #464

Merged
merged 1 commit into from Jun 9, 2019

Conversation

@ubruhin
Copy link
Member

commented Jun 8, 2019

After double-clicking on a footprint in the board editor (which opens the properties dialog), the editor changed back to the last active tool, which is of course not intended. Reason was a wrong return value of the state machine...

@ubruhin ubruhin added the bug label Jun 8, 2019

@ubruhin ubruhin added this to the 0.1.2 milestone Jun 8, 2019

@ubruhin ubruhin self-assigned this Jun 8, 2019

@ubruhin ubruhin merged commit e8586f9 into master Jun 9, 2019

10 checks passed

LibrePCB Build #20190608.2 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ubruhin ubruhin deleted the fix-boardeditor-leaving-state branch Jun 9, 2019

ubruhin added a commit that referenced this pull request Jul 8, 2019

Merge pull request #464 from LibrePCB/fix-boardeditor-leaving-state
BoardEditor: Fix unintended tool change after double click on footprint
(cherry picked from commit e8586f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.