Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
GraphicsView: Implement pinch to zoom #477
I have updated the pull request with a set of commits that I think should behave nicely for everyone.
I don't believe we need a preference setting to configure this. My intent is to leave mice behavior unchanged (including on Mac), but fix the currently broken trackpad behavior. I don't think anyone would want the existing trackpad behavior.
The commit fails CI on Ubuntu 14.04, I think because of an ancient version of Qt. Is that something you're interested in supporting? Canonical has dropped support for that platform already.
ubruhin left a comment •
Thanks for the PR! :)
I found some issues and have some questions/suggestions, see comments below.
As long as it's easy, I'd like to keep support for Qt 5.2. So far it was always very easy to keep this support, so I saw no reason to drop it. One of LibrePCB's goals is the availability on many different systems (architectures, operating systems, distributions etc.). For example Debian oldstable still has Qt 5.3.2, and I don't like to drop support for a still supported distribution if not absolutely necessary.
Thanks! Looks like you no longer use
Do I understand correctly that with this PR "pinch to zoom" works out-of-the-box on a MacBook?
I think there is still a small issue with the implementation: The method
Yup. I discovered that
I'll push a fix for this momentarily.