Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings when compiling with Qt 5.13 #478

Merged
merged 2 commits into from Jul 7, 2019

Conversation

@ubruhin
Copy link
Member

@ubruhin ubruhin commented Jul 7, 2019

CI on MacOS is currently broken because homebrew always installs the latest version of Qt, which is now Qt 5.13 and throws some deprecation warnings. This PR fixes the deprecation warnings to make CI successful again:

  • Replace qSort() by std::sort()
  • Replace QListWidgetItem::setBackgroundColor() by QListWidgetItem::setBackground()
@ubruhin ubruhin added this to the 0.1.2 milestone Jul 7, 2019
@ubruhin ubruhin self-assigned this Jul 7, 2019
- Replace qSort() by std::sort()
- Replace QListWidgetItem::setBackgroundColor() by
  QListWidgetItem::setBackground()
@ubruhin ubruhin force-pushed the fix-deprecation-warnings branch from 4bebb2d to 7017577 Jul 7, 2019
@ubruhin ubruhin merged commit e5d2bb2 into master Jul 7, 2019
11 checks passed
@ubruhin ubruhin deleted the fix-deprecation-warnings branch Jul 7, 2019
ubruhin added a commit that referenced this issue Jul 8, 2019
Fix deprecation warnings when compiling with Qt 5.13
(cherry picked from commit e5d2bb2)
@rnestler
Copy link
Member

@rnestler rnestler commented Jul 12, 2019

CI on MacOS is currently broken because homebrew always installs the latest version of Qt.

Should we change that to get more predictable CI? On the other hand it is nice to also test with the latest Qt version.

@ubruhin
Copy link
Member Author

@ubruhin ubruhin commented Jul 12, 2019

Should we change that to get more predictable CI? On the other hand it is nice to also test with the latest Qt version.

I would like to change it but didn't find a way to install a specific version of Qt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants