Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings when compiling with Qt 5.13 #478

Merged
merged 2 commits into from Jul 7, 2019

Conversation

@ubruhin
Copy link
Member

commented Jul 7, 2019

CI on MacOS is currently broken because homebrew always installs the latest version of Qt, which is now Qt 5.13 and throws some deprecation warnings. This PR fixes the deprecation warnings to make CI successful again:

  • Replace qSort() by std::sort()
  • Replace QListWidgetItem::setBackgroundColor() by QListWidgetItem::setBackground()

@ubruhin ubruhin added this to the 0.1.2 milestone Jul 7, 2019

@ubruhin ubruhin self-assigned this Jul 7, 2019

Fix deprecation warnings when compiling with Qt 5.13
- Replace qSort() by std::sort()
- Replace QListWidgetItem::setBackgroundColor() by
  QListWidgetItem::setBackground()

@ubruhin ubruhin force-pushed the fix-deprecation-warnings branch from 4bebb2d to 7017577 Jul 7, 2019

@ubruhin ubruhin merged commit e5d2bb2 into master Jul 7, 2019

11 checks passed

LibrePCB Build #20190707.9 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ubruhin ubruhin deleted the fix-deprecation-warnings branch Jul 7, 2019

ubruhin added a commit that referenced this pull request Jul 8, 2019

Merge pull request #478 from LibrePCB/fix-deprecation-warnings
Fix deprecation warnings when compiling with Qt 5.13
(cherry picked from commit e5d2bb2)
@rnestler

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

CI on MacOS is currently broken because homebrew always installs the latest version of Qt.

Should we change that to get more predictable CI? On the other hand it is nice to also test with the latest Qt version.

@ubruhin

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

Should we change that to get more predictable CI? On the other hand it is nice to also test with the latest Qt version.

I would like to change it but didn't find a way to install a specific version of Qt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.