Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent appearance of polygons between editor and Gerber export #479

Merged
merged 2 commits into from Jul 8, 2019

Conversation

@ubruhin
Copy link
Member

commented Jul 7, 2019

  • Only fill polygons if they are closed (filled but non-closed polygons look strange -> avoid them).
  • Fix missing area of filled polygons in Gerber export (filled polygons were drawn correctly in editors, but wrong in Gerber export).

Fixes #473

#478 must be merged first since CI is currently broken for MacOS.

@ubruhin ubruhin added the bug label Jul 7, 2019

@ubruhin ubruhin added this to the 0.1.2 milestone Jul 7, 2019

@ubruhin ubruhin self-assigned this Jul 7, 2019

@ubruhin ubruhin force-pushed the fix-polygon-fill branch from 1770dcf to b578b21 Jul 7, 2019

@ubruhin ubruhin merged commit 0c789a8 into master Jul 8, 2019

11 checks passed

LibrePCB Build #20190707.14 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ubruhin ubruhin deleted the fix-polygon-fill branch Jul 8, 2019

ubruhin added a commit that referenced this pull request Jul 8, 2019

Merge pull request #479 from LibrePCB/fix-polygon-fill
Fix inconsistent appearance of polygons between editor and Gerber export
(cherry picked from commit 0c789a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.