Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent appearance of polygons between editor and Gerber export #479

Merged
merged 2 commits into from Jul 8, 2019

Conversation

@ubruhin
Copy link
Member

@ubruhin ubruhin commented Jul 7, 2019

  • Only fill polygons if they are closed (filled but non-closed polygons look strange -> avoid them).
  • Fix missing area of filled polygons in Gerber export (filled polygons were drawn correctly in editors, but wrong in Gerber export).

Fixes #473

#478 must be merged first since CI is currently broken for MacOS.

@ubruhin ubruhin added the bug label Jul 7, 2019
@ubruhin ubruhin added this to the 0.1.2 milestone Jul 7, 2019
@ubruhin ubruhin self-assigned this Jul 7, 2019
@ubruhin ubruhin force-pushed the fix-polygon-fill branch from 1770dcf to b578b21 Jul 7, 2019
@ubruhin ubruhin merged commit 0c789a8 into master Jul 8, 2019
11 checks passed
@ubruhin ubruhin deleted the fix-polygon-fill branch Jul 8, 2019
ubruhin added a commit that referenced this issue Jul 8, 2019
Fix inconsistent appearance of polygons between editor and Gerber export
(cherry picked from commit 0c789a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant