Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle in the menu bar for dock widgets #487

Merged
merged 1 commit into from Jul 28, 2019

Conversation

jeffwheeler
Copy link
Contributor

@jeffwheeler jeffwheeler commented Jul 21, 2019

Prior to this commit, it is impossible to restore dock widgets that were accidentally closed, except by deleting the QSettings storage.

@jeffwheeler
Copy link
Contributor Author

jeffwheeler commented Jul 21, 2019

I built this because of the bug solved in #488, but it remains relevant after that bug is fixed.

@ubruhin
Copy link
Member

ubruhin commented Jul 23, 2019

Thanks for the PR, but actually the dock widgets can already be restored with a right click on a toolbar or menubar 😉

grafik

I think in most software this is the way to toggle visibility of toolbars and docks. Or isn't this working for you?

@jeffwheeler
Copy link
Contributor Author

jeffwheeler commented Jul 24, 2019

The bug described in #488 unfortunately removes all toolbars and menu bars, so there's nowhere to right click.

image

I'm not sure about Linux (Ubuntu?), but on Mac, there's typically menus for this. It makes discovery much easier.

Screen Shot 2019-07-23 at 7 21 00 PM

@ubruhin
Copy link
Member

ubruhin commented Jul 27, 2019

Hmm okay, very strange :(

So then I agree to add these menu items. But actually I would expect them in the "View" menu, not in "Tools" (tools is virtually coupled to the corresponding toolbar on the left side, it's not meant to contain other menu items). Could you update the PR accordingly?

Prior to this commit, it is impossible to restore dock widgets that were
accidentally closed, except by deleting the QSettings storage.
@jeffwheeler
Copy link
Contributor Author

jeffwheeler commented Jul 28, 2019

Done.

@ubruhin
Copy link
Member

ubruhin commented Jul 28, 2019

Perfect, thanks! 😃

@ubruhin ubruhin added enhancement UI / UX labels Jul 28, 2019
@ubruhin ubruhin added this to the 0.1.3 milestone Jul 28, 2019
@ubruhin ubruhin merged commit f9a994c into LibrePCB:master Jul 28, 2019
10 checks passed
@jeffwheeler jeffwheeler deleted the add_dock_toggle_menus branch Jul 28, 2019
ubruhin added a commit that referenced this issue Nov 17, 2019
Add toggle in the menu bar for dock widgets
(cherry picked from commit f9a994c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement UI / UX
Development

Successfully merging this pull request may close these issues.

None yet

2 participants