Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle in the menu bar for dock widgets #487

Merged
merged 1 commit into from Jul 28, 2019

Conversation

@jeffwheeler
Copy link
Contributor

jeffwheeler commented Jul 21, 2019

Prior to this commit, it is impossible to restore dock widgets that were accidentally closed, except by deleting the QSettings storage.

@jeffwheeler

This comment has been minimized.

Copy link
Contributor Author

jeffwheeler commented Jul 21, 2019

I built this because of the bug solved in #488, but it remains relevant after that bug is fixed.

@ubruhin

This comment has been minimized.

Copy link
Member

ubruhin commented Jul 23, 2019

Thanks for the PR, but actually the dock widgets can already be restored with a right click on a toolbar or menubar 😉

grafik

I think in most software this is the way to toggle visibility of toolbars and docks. Or isn't this working for you?

@jeffwheeler

This comment has been minimized.

Copy link
Contributor Author

jeffwheeler commented Jul 24, 2019

The bug described in #488 unfortunately removes all toolbars and menu bars, so there's nowhere to right click.

image

I'm not sure about Linux (Ubuntu?), but on Mac, there's typically menus for this. It makes discovery much easier.

Screen Shot 2019-07-23 at 7 21 00 PM

@ubruhin

This comment has been minimized.

Copy link
Member

ubruhin commented Jul 27, 2019

Hmm okay, very strange :(

So then I agree to add these menu items. But actually I would expect them in the "View" menu, not in "Tools" (tools is virtually coupled to the corresponding toolbar on the left side, it's not meant to contain other menu items). Could you update the PR accordingly?

Prior to this commit, it is impossible to restore dock widgets that were
accidentally closed, except by deleting the QSettings storage.
@jeffwheeler jeffwheeler force-pushed the jeffwheeler:add_dock_toggle_menus branch from 02b6574 to 0c0da3f Jul 28, 2019
@jeffwheeler

This comment has been minimized.

Copy link
Contributor Author

jeffwheeler commented Jul 28, 2019

Done.

@ubruhin

This comment has been minimized.

Copy link
Member

ubruhin commented Jul 28, 2019

Perfect, thanks! 😃

@ubruhin ubruhin added this to the 0.1.3 milestone Jul 28, 2019
@ubruhin ubruhin merged commit f9a994c into LibrePCB:master Jul 28, 2019
10 checks passed
10 checks passed
LibrePCB Build #20190728.1 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jeffwheeler jeffwheeler deleted the jeffwheeler:add_dock_toggle_menus branch Jul 28, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
Add toggle in the menu bar for dock widgets
(cherry picked from commit f9a994c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.