Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board editor: Fix invisible zero-width circles/polygons #502

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@ubruhin
Copy link
Member

ubruhin commented Aug 21, 2019

Circles and polygons with zero width were not shown until now, but they should be visible independent of their width. I guess this is just a leftover from a long time ago when polygons were implemented quite different than now...

@ubruhin ubruhin added the bug label Aug 21, 2019
@ubruhin ubruhin added this to the 0.1.3 milestone Aug 21, 2019
@ubruhin ubruhin self-assigned this Aug 21, 2019
Circles and polygons with zero width were not shown until now, but they
should be visible independent of their width.
@ubruhin ubruhin force-pushed the fix-invisible-zero-width-polygons branch from 612ce36 to 46e0fad Aug 21, 2019
@ubruhin ubruhin changed the title Board editor: Fix invisible zero-width polygons Board editor: Fix invisible zero-width circles/polygons Aug 21, 2019
@dbrgn
dbrgn approved these changes Aug 21, 2019
Copy link
Member

dbrgn left a comment

🎉

@ubruhin ubruhin merged commit 37dc146 into master Aug 22, 2019
11 checks passed
11 checks passed
LibrePCB Build #20190821.5 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ubruhin ubruhin deleted the fix-invisible-zero-width-polygons branch Aug 22, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
Board editor: Fix invisible zero-width circles/polygons
(cherry picked from commit 37dc146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.