Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken window settings when closing windows with OpenGL enabled #503

Merged
merged 4 commits into from Aug 25, 2019

Conversation

@ubruhin
Copy link
Member

ubruhin commented Aug 22, 2019

  • Use QOpenGLWidget instead of QGLWidget fixes possibly broken client settings
  • Add functional tests for window state save/restore

See discussion in #488.

@ubruhin ubruhin added this to the 0.1.3 milestone Aug 22, 2019
@ubruhin ubruhin self-assigned this Aug 22, 2019
@ubruhin ubruhin force-pushed the fix-window-state-save branch 2 times, most recently from 7af7871 to 5550d28 Aug 25, 2019
@ubruhin ubruhin force-pushed the fix-window-state-save branch from 5550d28 to 7f7ec81 Aug 25, 2019
@ubruhin ubruhin merged commit 669e485 into master Aug 25, 2019
11 checks passed
11 checks passed
LibrePCB Build #20190825.10 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ubruhin ubruhin deleted the fix-window-state-save branch Aug 25, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
Fix broken window settings when closing windows with OpenGL enabled
(cherry picked from commit 669e485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.