Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gerber export: Add support for non-square octagon pads #507

Merged
merged 2 commits into from Sep 1, 2019

Conversation

@ubruhin
Copy link
Member

ubruhin commented Aug 31, 2019

Octagon footprint pads with width!=height were not supported until now (error during Gerber export). This fixes the error and exports the pads properly.

@ubruhin ubruhin added the gerber label Aug 31, 2019
@ubruhin ubruhin self-assigned this Aug 31, 2019
@ubruhin ubruhin added this to the 0.1.3 milestone Aug 31, 2019
@ubruhin ubruhin merged commit 057f06d into master Sep 1, 2019
11 checks passed
11 checks passed
LibrePCB Build #20190831.2 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ubruhin ubruhin deleted the gerber-octagon-support branch Sep 1, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
Gerber export: Add support for non-square octagon pads
(cherry picked from commit 057f06d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.