Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace spinboxes/comboboxes with unit-aware edit widgets #520

Merged
merged 7 commits into from Sep 24, 2019

Conversation

@ubruhin
Copy link
Member

ubruhin commented Sep 22, 2019

#519 added the LengthEdit and AngleEdit widgets, which simplify the handling of Length resp. Angle values in the GUI. Thus now I also added UnsignedLengthEdit, PositiveLengthEdit, RatioEdit and UnsignedRatioEdit and refactored a lot of GUI code to use these new widgets. Basically it's a code refactoring, but it also leads to small user experience improvements since the unit (e.g. mm, % or °) is now shown in most number input fields.

@ubruhin ubruhin added this to the 0.1.3 milestone Sep 22, 2019
@ubruhin ubruhin self-assigned this Sep 22, 2019
@ubruhin ubruhin force-pushed the use-unit-edit-widgets branch from 08be173 to 46e7ad5 Sep 22, 2019
@ubruhin ubruhin merged commit e84e876 into master Sep 24, 2019
11 checks passed
11 checks passed
LibrePCB Build #20190922.9 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ubruhin ubruhin deleted the use-unit-edit-widgets branch Sep 24, 2019
@ubruhin ubruhin added this to Done in Improve code quality Sep 26, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
Replace spinboxes/comboboxes with unit-aware edit widgets
(cherry picked from commit e84e876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.