Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library editor: Adjust default values of sym/pkg elements #523

Merged
merged 2 commits into from Sep 28, 2019

Conversation

@ubruhin
Copy link
Member

ubruhin commented Sep 26, 2019

When creating symbols or packages, some properties were initialized with default values which aren't reasonable IMHO. Thus I reviewed and documented (in code) all default values and adjusted some of them.

To comply with our library conventions:

  • Footprint circle line width changed from 0.254mm to 0.2mm

To avoid unnecessary grab areas "by accident":

  • Footprint circle/polygon grab area disabled

To avoid inch-based numbers with many decimal places where metric numbers could be used instead (most spinboxes have an interval of 0.1mm, thus it's more reasonable to use default numbers which are a multiple of 0.1mm):

  • Footprint THT pad size changed from 1.27mm x 0.635mm to 1.5mm x 0.7mm
  • Footprint SMT pad size changed from 2.54mm x 1.27mm to 2.5mm x 1.3mm
  • Symbol text height changed from 2.54mm to 2.5mm
  • Symbol circle/polygon line width changed from 0.254mm to 0.2mm

The latter change is actually the one with the most impact; it would require to adjust all already existing symbols to use an outline width of 0.2mm instead of 0.254mm. Actually the symbol outline width is not documented yet in our library conventions, but I would now recommend to use 0.2mm. Same for text height, I would recommend 2.5mm instead of 2.54mm. Or what do you think @dbrgn?

@ubruhin ubruhin added this to the 0.1.3 milestone Sep 26, 2019
@ubruhin ubruhin requested a review from dbrgn Sep 26, 2019
@dbrgn

This comment has been minimized.

Copy link
Member

dbrgn commented Sep 26, 2019

it would require to adjust all already existing symbols to use an outline width of 0.2mm instead of 0.254mm.

It doesn't require us to do so, but of course it would be nice to adjust them.

I like the new metric defaults.

@ubruhin ubruhin mentioned this pull request Sep 27, 2019
@ubruhin

This comment has been minimized.

Copy link
Member Author

ubruhin commented Sep 28, 2019

OK, the new defaults are now documented in the library conventions (see LibrePCB/librepcb-doc#38).

It doesn't require us to do so, but of course it would be nice to adjust them.

Correct :)

@ubruhin ubruhin merged commit 4d1cb87 into master Sep 28, 2019
11 checks passed
11 checks passed
LibrePCB Build #20190926.8 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ubruhin ubruhin deleted the cleanup-library-editor-defaults branch Sep 28, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
Library editor: Adjust default values of sym/pkg elements
(cherry picked from commit 4d1cb87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.