Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board editor: Allow rotate while moving items #533

Merged
merged 3 commits into from Oct 10, 2019

Conversation

@ubruhin
Copy link
Member

ubruhin commented Oct 6, 2019

While moving items (left mouse button pressed), the items can now be rotated either by pressing 'R' or by right-clicking. Now it's consistent to the behavior when placing new devices.

Thanks to some refactoring, more code was removed than added 馃榿

Fixes #528

@ubruhin ubruhin added this to the 0.1.3 milestone Oct 6, 2019
@ubruhin ubruhin self-assigned this Oct 6, 2019
@ubruhin ubruhin added this to In Progress in Improve user experience of GUI Oct 6, 2019
@ubruhin ubruhin force-pushed the 528-boardeditor-rotate-while-move branch from e40772c to 6139d70 Oct 6, 2019
@ubruhin ubruhin force-pushed the 528-boardeditor-rotate-while-move branch from 6139d70 to 89493c7 Oct 9, 2019
@ubruhin ubruhin merged commit 2e74721 into master Oct 10, 2019
11 checks passed
11 checks passed
LibrePCB Build #20191009.3 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ubruhin ubruhin deleted the 528-boardeditor-rotate-while-move branch Oct 10, 2019
@ubruhin ubruhin moved this from In Progress to Done in Improve user experience of GUI Oct 10, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
Board editor: Allow rotate while moving items
(cherry picked from commit 2e74721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can鈥檛 perform that action at this time.