Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic editor: Fix device when adding component multiple times #561

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@ubruhin
Copy link
Member

ubruhin commented Oct 20, 2019

When adding a component with a pre-selected device multiple times to a schematic, the device was set only on the first component placed. All successive components didn't have a device selected.

Fixes #547

@ubruhin ubruhin added the bug label Oct 20, 2019
@ubruhin ubruhin added this to the 0.1.3 milestone Oct 20, 2019
@ubruhin ubruhin self-assigned this Oct 20, 2019
@dbrgn
dbrgn approved these changes Oct 20, 2019
Copy link
Member

dbrgn left a comment

If I understand this correctly, the device was passed to the first "add" command, but not to subsequent ones, right?

@ubruhin

This comment has been minimized.

Copy link
Member Author

ubruhin commented Oct 20, 2019

If I understand this correctly, the device was passed to the first "add" command, but not to subsequent ones, right?

Correct :)

When adding a component with a pre-selected device multiple times to
a schematic, the device was set only on the first component placed. All
successive components didn't have a device selected.
@ubruhin ubruhin force-pushed the 547-fix-add-component-default-device branch from e616ae9 to 389ddb8 Oct 21, 2019
@ubruhin ubruhin merged commit c7b5c2f into master Oct 22, 2019
11 checks passed
11 checks passed
LibrePCB Build #20191021.7 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ubruhin ubruhin deleted the 547-fix-add-component-default-device branch Oct 22, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
…evice

Schematic editor: Fix device when adding component multiple times
(cherry picked from commit c7b5c2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.