Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibraryEditor: Fix missing message box when closing tab #563

Merged
merged 1 commit into from Oct 27, 2019

Conversation

@ubruhin
Copy link
Member

ubruhin commented Oct 25, 2019

When closing a tab in the library editor while some property (like name,
description, ...) was just modified, the "save changes?" message box did
not appear. Now the focus is explicitly moved out from the editor widget
to ensure the "dirty" state of editors gets updated when closing a tab.

Fixes #492.

When closing a tab in the library editor while some property (like name,
description, ...) was just modified, the "save changes?" message box did
not appear. Now the focus is explicitly moved out from the editor widget
to ensure the "dirty" state of editors gets updated when closing a tab.
@ubruhin ubruhin added this to the 0.1.3 milestone Oct 25, 2019
@ubruhin ubruhin self-assigned this Oct 25, 2019
@dbrgn

This comment has been minimized.

Copy link
Member

dbrgn commented Oct 25, 2019

Cool! Does this only apply to closing, or also when pressing "apply"?

It regularly happens to me that I update a value (e.g. a polygon point), then press "apply", but nothing happens because the focus is still on the input field.

@ubruhin

This comment has been minimized.

Copy link
Member Author

ubruhin commented Oct 26, 2019

Does this only apply to closing, or also when pressing "apply"?

It applies only to closing tabs, it's not related to dialogs.

It regularly happens to me that I update a value (e.g. a polygon point), then press "apply", but nothing happens because the focus is still on the input field.

Good point, but I'll try to fix it in a separate PR since it's a different topic.

@ubruhin ubruhin merged commit 9c960eb into master Oct 27, 2019
11 checks passed
11 checks passed
LibrePCB Build #20191025.2 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ubruhin ubruhin deleted the 492-libraryeditor-tab-close-clear-focus branch Oct 27, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
…ar-focus

LibraryEditor: Fix missing message box when closing tab
(cherry picked from commit 9c960eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.