New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Create archive for deployment on Linux #571
Conversation
Cool, that probably fixes the deployment issues that @PatrickFranken had as well, right? |
Actually I don't know (yet), but if he used the installer, then probably yes :) Btw, I forgot to mention that the new archive can be "reviewed" here: https://download.librepcb.org/nightly_builds/ci-build-linux-archive/librepcb-nightly-linux-x86_64.tar.gz |
No, the AppImage, which segfaulted on his server... |
Btw, I forgot to mention that the new archive can be "reviewed" here: https://download.librepcb.org/nightly_builds/ci-build-linux-archive/librepcb-nightly-linux-x86_64.tar.gz
The archive currently contains a root directory called .
. This results in the files being extracted into the current directory, without a containing root directory.
It would be good if the archive contained a root directory called librepcb
or librepcb-nightly-linux-x86_64
.
(The binaries work though!)
Hmm yeah that was indeed strange...
Actually I don't like having a root directory in an archive (the purpose of an archive is to bundle multiple files into one file, so why move them all into a useless subdirectory). But (unfortunately) it seems to be common practice to do so, thus I added the root directory Or is it also accepted to put the actual files into the root of a tar archive? |
No, a root directory is more common. If you don't want the root dir, you can use |
OK the archive now contains the root directory |
CI: Create archive for deployment on Linux (cherry picked from commit 38812d3)
Currently we provide two ways to install LibrePCB binaries on Linux: Installer and AppImage. But the installer is a pain for automated installation, and the AppImage does not work out-of-the-box in Docker containers (because FUSE is missing). To avoid these issues, I think it makes sense to also provide the binaries in a *.tar.gz archive for Linux. It's basically "for free", since we just need to bundle the already available binaries in a *.tar.gz.
Interestingly I also realized that the
librepcb-cli
currently doesn't work on Linux when installed with the installer, because that binary was not patched withlinuxdeployqt
. That's also fixed with this PR, so it should now work on Linux too.