Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlPanel::projectEditorClosed: Use toUnique on file path #573

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@dbrgn
Copy link
Member

dbrgn commented Nov 9, 2019

Because the toUnique call was missing, projects on a symlinked path
were not removed from the mOpenProjectEditors hash map. This in turn
would trigger a segfault when reopening a project due to a
use-after-free.

Fixes #432.

Because the `toUnique` call was missing, projects on a symlinked path
were not removed from the `mOpenProjectEditors` hash map. This in turn
would trigger a segfault when reopening a project due to a
use-after-free.
@dbrgn dbrgn added the bug label Nov 9, 2019
@dbrgn dbrgn requested a review from ubruhin Nov 9, 2019
@ubruhin ubruhin added this to the 0.1.3 milestone Nov 11, 2019
@ubruhin

This comment has been minimized.

Copy link
Member

ubruhin commented Nov 11, 2019

Nice catch, thanks! 😃

@ubruhin ubruhin merged commit c292ef0 into master Nov 11, 2019
11 checks passed
11 checks passed
LibrePCB Build #20191109.2 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ubruhin ubruhin deleted the fix-segfault-on-project-reopen branch Nov 11, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
ControlPanel::projectEditorClosed: Use toUnique on file path
(cherry picked from commit c292ef0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.