Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possibly wrong grab area of various graphics items #582

Merged
merged 2 commits into from Nov 17, 2019

Conversation

@ubruhin
Copy link
Member

ubruhin commented Nov 16, 2019

The shape was sometimes not calculated properly in Toolbox::shapeFromPath(), which lead to wrong grab areas of polygons and probably other graphics items, especially after modifying their properties.

Fixes #578

ubruhin added 2 commits Nov 16, 2019
The shape was sometimes not calculated properly in
Toolbox::shapeFromPath(), which lead to wrong grab areas of polygons
and probably other graphics items, especially after modifying their
properties.
@ubruhin ubruhin added this to the 0.1.3 milestone Nov 16, 2019
@ubruhin ubruhin self-assigned this Nov 16, 2019
@ubruhin ubruhin merged commit bd616e1 into master Nov 17, 2019
11 checks passed
11 checks passed
LibrePCB Build #20191116.4 succeeded
Details
LibrePCB (Doxygen) Doxygen succeeded
Details
LibrePCB (Linux Ubuntu_1404_GCC) Linux Ubuntu_1404_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_GCC) Linux Ubuntu_1604_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1604_Qt_5_12_3_GCC) Linux Ubuntu_1604_Qt_5_12_3_GCC succeeded
Details
LibrePCB (Linux Ubuntu_1804_Clang) Linux Ubuntu_1804_Clang succeeded
Details
LibrePCB (Linux Ubuntu_1904_GCC9) Linux Ubuntu_1904_GCC9 succeeded
Details
LibrePCB (Stylecheck) Stylecheck succeeded
Details
LibrePCB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ubruhin ubruhin deleted the 578-fix-wrong-graphicsitem-grab-area branch Nov 17, 2019
ubruhin added a commit that referenced this pull request Nov 17, 2019
…-area

Fix possibly wrong grab area of various graphics items
(cherry picked from commit bd616e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.