Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex of various constrained strings #637

Merged
merged 1 commit into from Dec 27, 2019

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Dec 26, 2019

The regex to check following constrained strings allowed a trailing newline by accident (see #603):

  • AttributeKey
  • CircuitIdentifier
  • ComponentPrefix
  • ComponentSymbolVariantItemSuffix
  • GraphicsLayerName
  • Uuid

Fixed the regex by using "\A" instead of "^" and "\z" instead of "$".
Also added some unit tests to check for correct behavior.

Fixes #603.

The regex to check following constrained strings allowed a trailing
newline by accident:

- AttributeKey
- CircuitIdentifier
- ComponentPrefix
- ComponentSymbolVariantItemSuffix
- GraphicsLayerName
- Uuid

Fixed the regex by using "\A" instead of "^" and "\z" instead of "$".
Also added some unit tests to check for correct behavior.
@ubruhin ubruhin added the bug label Dec 26, 2019
@ubruhin ubruhin added this to the 0.1.4 milestone Dec 26, 2019
@ubruhin ubruhin self-assigned this Dec 26, 2019
@ubruhin ubruhin merged commit 29abc2a into master Dec 27, 2019
11 checks passed
@ubruhin ubruhin deleted the 603-fix-newline-in-net-names branch Dec 27, 2019
ubruhin added a commit that referenced this issue Apr 22, 2020
Fix regex of various constrained strings
(cherry picked from commit 29abc2a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant