Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Editor: Support moving elements to other library #638

Merged
merged 1 commit into from Dec 27, 2019

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Dec 26, 2019

grafik

This is especially useful to move library elements from your own library to an official library, i.e. following workflow:

  1. Add all new elements to your own library first
  2. Use these elements in your PCB, manufacture and test the PCB
  3. If needed, fix issues in the library elements
  4. Move library elements to the corresponding official library
  5. Open GitHub pull request to include your library element

Until now, step 4 was possible only by manually moving files around between the libraries. This PR simplifies this by integrating the action into the library editor.

@ubruhin ubruhin added enhancement UI / UX labels Dec 26, 2019
@ubruhin ubruhin added this to the 0.1.4 milestone Dec 26, 2019
@ubruhin ubruhin self-assigned this Dec 26, 2019
@ouabache
Copy link

@ouabache ouabache commented Dec 26, 2019

@dbrgn
Copy link
Member

@dbrgn dbrgn commented Dec 26, 2019

Awesome, makes the workflow much easier 🙂

What happens if you try to load both libraries at the same time?

If the version is identical, the element will be picked randomly from one of the libraries. That's fine if there are no changes. Otherwise, bump the version, then LibrePCB will pick the library element with the highest version.

@ubruhin
Copy link
Member Author

@ubruhin ubruhin commented Dec 26, 2019

Does it modify the UUID's ?

No, basically only the directory of the library element is moved to the other library, i.e. UUIDs are not modified.

What happens if you try to load both libraries at the same time?

You mean, if the editors of both libraries are opened? That's no problem, the element will be closed automatically in the old library and after the library scan finished, the element appears in the new library.

@ouabache
Copy link

@ouabache ouabache commented Dec 26, 2019

@ubruhin
Copy link
Member Author

@ubruhin ubruhin commented Dec 26, 2019

@ouabache I don't understand what you mean exactly. The library element is not copied, but moved to another library. So there is no issue with duplicate, old vs. new, version number or something else. Everything works exactly the same way as before moving, the element is just located in a different library.

@ouabache
Copy link

@ouabache ouabache commented Dec 26, 2019

@ubruhin ubruhin force-pushed the support-moving-library-elements branch from 3cab01f to a7f91e8 Compare Dec 27, 2019
@ubruhin ubruhin changed the title Library Editor: Allow moving elements to other library Library Editor: Support moving elements to other library Dec 27, 2019
@ubruhin ubruhin merged commit b235119 into master Dec 27, 2019
11 checks passed
@ubruhin ubruhin deleted the support-moving-library-elements branch Dec 27, 2019
ubruhin added a commit that referenced this issue Apr 22, 2020
Library Editor: Support moving elements to other library
(cherry picked from commit b235119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement UI / UX
Development

Successfully merging this pull request may close these issues.

None yet

3 participants