Library Editor: Support moving elements to other library

[ubruhin]

This is especially useful to move library elements from your own library to an official library, i.e. following workflow:

1. Add all new elements to your own library first
2. Use these elements in your PCB, manufacture and test the PCB
3. If needed, fix issues in the library elements
4. Move library elements to the corresponding official library
5. Open GitHub pull request to include your library element

Until now, step 4 was possible only by manually moving files around between the libraries. This PR simplifies this by integrating the action into the library editor.

[ouabache]

Does it modify the UUID's ? What happens if you try to load both libraries at the same time?

…

On Thu, Dec 26, 2019 at 6:07 AM U. Bruhin ***@***.***> wrote: [image: grafik] <https://user-images.githubusercontent.com/5374821/71478552-9abe0480-27f0-11ea-8279-eb5483e4737f.png> This is especially useful to move library elements from your own library to an official library, i.e. following workflow: 1. Add all new elements to your own library first 2. Use these elements in your PCB, manufacture and test the PCB 3. If needed, fix issues in the library elements 4. Move library elements to the corresponding official library 5. Open GitHub pull request to include your library element Until now, step 4 was possible only by manually moving files around between the libraries. This PR simplifies this by integrating the action into the library editor. ------------------------------ You can view, comment on, or merge this pull request online at: #638 Commit Summary - LibraryEditor: Allow moving elements to other library File Changes - *A* img/actions/move_to.png <https://github.com/LibrePCB/LibrePCB/pull/638/files#diff-0> (0) - *M* img/images.qrc <https://github.com/LibrePCB/LibrePCB/pull/638/files#diff-1> (1) - *M* libs/librepcb/libraryeditor/lib/libraryoverviewwidget.cpp <https://github.com/LibrePCB/LibrePCB/pull/638/files#diff-2> (86) - *M* libs/librepcb/libraryeditor/lib/libraryoverviewwidget.h <https://github.com/LibrePCB/LibrePCB/pull/638/files#diff-3> (10) Patch Links: - https://github.com/LibrePCB/LibrePCB/pull/638.patch - https://github.com/LibrePCB/LibrePCB/pull/638.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#638?email_source=notifications&email_token=AAKX3XH3DPRUNWXVKG6FQJ3Q2S3C7A5CNFSM4J7LX7N2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICW4PTA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKX3XEZJSKWEKZTLEGTWALQ2S3C7ANCNFSM4J7LX7NQ> .

[dbrgn]

Awesome, makes the workflow much easier 🙂

What happens if you try to load both libraries at the same time?

If the version is identical, the element will be picked randomly from one of the libraries. That's fine if there are no changes. Otherwise, bump the version, then LibrePCB will pick the library element with the highest version.

[ubruhin]

Does it modify the UUID's ?

No, basically only the directory of the library element is moved to the other library, i.e. UUIDs are not modified.

What happens if you try to load both libraries at the same time?

You mean, if the editors of both libraries are opened? That's no problem, the element will be closed automatically in the old library and after the library scan finished, the element appears in the new library.

[ouabache]

And what happens the next time you run librePCB? It no longer knows which one was old or new. How does it choose the correct one? If it finds one in a remote lib and a duplicate in local then it should choose local because that means you are editing it and need to be able to test your edits.

…

On Thu, Dec 26, 2019 at 10:44 AM U. Bruhin ***@***.***> wrote: Does it modify the UUID's ? No, basically only the directory of the library element is moved to the other library, i.e. UUIDs are not modified. What happens if you try to load both libraries at the same time? You mean, if the editors of both libraries are opened? That's no problem, the element will be closed automatically in the old library and after the library scan finished, the element appears in the new library. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#638?email_source=notifications&email_token=AAKX3XAAGGDDYRMQPWU4FCTQ2T3QLA5CNFSM4J7LX7N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHV7UAY#issuecomment-569113091>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKX3XHQM727R6ATXHPM56TQ2T3QLANCNFSM4J7LX7NQ> .

[ubruhin]

@ouabache I don't understand what you mean exactly. The library element is not copied, but moved to another library. So there is no issue with duplicate, old vs. new, version number or something else. Everything works exactly the same way as before moving, the element is just located in a different library.

[ouabache]

OK, I was thinking about a copy

…

On Thu, Dec 26, 2019 at 12:49 PM U. Bruhin ***@***.***> wrote: @ouabache <https://github.com/ouabache> I don't understand what you mean exactly. The library element is *not copied*, but *moved* to another library. So there is no issue with duplicate, old vs. new, version number or something else. Everything works exactly the same way as before moving, the element is just located in a different library. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#638?email_source=notifications&email_token=AAKX3XGXKMJBSQUDK56QDILQ2UKGLA5CNFSM4J7LX7N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHWEDQI#issuecomment-569131457>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKX3XD5RFFSRLSLMCHRXWDQ2UKGLANCNFSM4J7LX7NQ> .