Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workspace settings code #645

Merged
merged 8 commits into from Jan 3, 2020
Merged

Refactor workspace settings code #645

merged 8 commits into from Jan 3, 2020

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Jan 2, 2020

Actually I'm working on the file format migration required to work towards the 0.2.x release, but the current software architecture of workspace settings lead to some frustration. I realized that this (pretty old) code has some fundamental issues, thus I did some refactoring.

Main improvements:

  • Strictly separate data from GUI
  • Simplify architecture to reduce boilerplate code
  • Fixes #611 since it was caused by the bad architecture

Due to the refactoring (which increases reusability of widgets), some GUI elements are now slightly different. For example these tables in workspace settings:

grafik

@ubruhin ubruhin added this to the 0.1.4 milestone Jan 2, 2020
@ubruhin ubruhin self-assigned this Jan 2, 2020
@ubruhin ubruhin force-pushed the refactor-workspace-settings branch from 7b68d44 to 3695664 Compare Jan 2, 2020
ubruhin added 2 commits Jan 2, 2020
Refactoring which reduces lines of code.
- Decoupling data from GUI
- Reducing lines of code
- General code cleanup
@ubruhin ubruhin force-pushed the refactor-workspace-settings branch from 3695664 to 1c7c6c0 Compare Jan 2, 2020
@ubruhin ubruhin merged commit 59086be into master Jan 3, 2020
11 checks passed
@ubruhin ubruhin deleted the refactor-workspace-settings branch Jan 3, 2020
ubruhin added a commit that referenced this issue Apr 22, 2020
Refactor workspace settings code
(cherry picked from commit 59086be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant