Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device editor: Show warning if no pads are connected #680

Merged
merged 1 commit into from Apr 4, 2020

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Mar 23, 2020

Shows a warning in the device editor if there are package pads, but none of them is connected. As soon as one pad gets connected, the message disappears.

I used the severity "warning" instead of "error" because there are situations where this message is a false-positive: If the package has only pads for mechanical reasons, but does not provide an electrical functionality, this message needs to be ignored.

Fixes #412

@ubruhin ubruhin added UI / UX tool-library-editor labels Mar 23, 2020
@ubruhin ubruhin added this to the 0.1.4 milestone Mar 23, 2020
@ubruhin ubruhin requested a review from dbrgn Mar 23, 2020
@ubruhin ubruhin force-pushed the 412-device-check-for-unconnected-pads branch from d686cd1 to 39d9bb0 Compare Mar 28, 2020
@ubruhin ubruhin force-pushed the 412-device-check-for-unconnected-pads branch from 39d9bb0 to f12bc9e Compare Apr 2, 2020
@ubruhin ubruhin merged commit c1e5911 into master Apr 4, 2020
11 checks passed
@ubruhin ubruhin deleted the 412-device-check-for-unconnected-pads branch Apr 4, 2020
ubruhin added a commit that referenced this issue Apr 22, 2020
…d-pads

Device editor: Show warning if no pads are connected
(cherry picked from commit c1e5911)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool-library-editor UI / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant