Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchematicPagesDock: Disable wrapping of schematic pages #685

Merged
merged 1 commit into from Apr 14, 2020

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Apr 13, 2020

If there is not enough space available to display the schematic pages in a vertical layout, QListWidget was allowed to wrap pages to the right, i.e. using a horizontal layout. In some situations (depending on the width of the dock widget), the wrapped pages were not visible anymore, so it looked like some schematic pages disappeared. By disabling wrapping, QListWidget always uses a vertical layout.

Fixes #681

If there is not enough space available to display the schematic pages
in a vertical layout, QListWidget was allowed to wrap pages to the
right, i.e. using a horizontal layout. In some situations (depending on
the width of the dock widget), the wrapped pages were not visible
anymore, so it looked like some schematic pages disappeared. By
disabling wrapping, QListWidget always uses a vertical layout.
@ubruhin ubruhin added bug UI / UX tool-schematics-editor labels Apr 13, 2020
@ubruhin ubruhin added this to the 0.1.4 milestone Apr 13, 2020
@ubruhin ubruhin self-assigned this Apr 13, 2020
dbrgn
dbrgn approved these changes Apr 13, 2020
@ubruhin ubruhin merged commit 682419d into master Apr 14, 2020
11 checks passed
@ubruhin ubruhin deleted the 681-fix-disappearing-schematic-pages branch Apr 14, 2020
ubruhin added a commit that referenced this issue Apr 22, 2020
…pages

SchematicPagesDock: Disable wrapping of schematic pages
(cherry picked from commit 682419d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants