Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect configured grid unit in statusbar #689

Merged
merged 6 commits into from Apr 26, 2020

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Apr 26, 2020

In #684 I adjusted the editors to display the cursor position in the statusbar in the unit from workspace settings. But now while testing the 0.1.4 release candidate I realized that it probably makes even more sense to use the unit configured in the grid settings of the opened editor. So for example if you configure the schematics grid to 0.1 inches, the schematic editor will show the cursor position in inches too, while at the same time the board editor might show Millimeters if the board grid is set to e.g. 0.1mm.

In addition, I completely refactored and cleaned up the grid settings dialog. It is now also using the new length edit widget instead of using spinbox+buttons+combobox.

Old:
grafik

New:
grafik

Summary: Less and cleaner code, simpler UI and more functionality 馃榿

ubruhin added 6 commits Apr 26, 2020
To edit a grid interval with LengthEditBas, some new features were
needed:

- Optionally make up/down buttons changing the value by factor 2
- Reset unit to default
- Emit signal if unit gets changed
- General refactoring, cleanup and GUI enhancements
- Use PositiveLengthEdit widget to edit the grid interval (instead of
  separate spinbox, buttons and combobox widgets)
@ubruhin ubruhin added this to the 0.1.4 milestone Apr 26, 2020
@ubruhin ubruhin self-assigned this Apr 26, 2020
@ubruhin ubruhin merged commit 42fb36c into master Apr 26, 2020
11 checks passed
@ubruhin ubruhin deleted the statusbar-unit-from-grid-settings branch Apr 26, 2020
ubruhin added a commit that referenced this issue Apr 26, 2020
Respect configured grid unit in statusbar
(cherry picked from commit 42fb36c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant