Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix stack overflow in pdf graphics2 d translate method(since f73467c) #306

Conversation

V-F
Copy link
Contributor

@V-F V-F commented Dec 11, 2019

BUG PdfGraphics2D: fixed StackOverflowError by calling PdfGraphics2D#translate(int,int) method (since f73467c commit).

@sixdouglas
Copy link
Contributor

Hi @V-F ,

Is this fixing any known issue?
If so, could you make a reference to it using the # followed by its id?
If not, could you open one explaining the problem and giving the smallest sample code possible to reproduce it?

Can you also add a test (unit or sample) to cover these changes? And maybe squashing your commits would be nice.

Thanks for your help

@V-F
Copy link
Contributor Author

V-F commented Dec 16, 2019

Opened issue #313
Sample of code can be used as test unit if you want.

@asturio asturio merged commit 7de53cc into LibrePDF:master Jan 15, 2020
@V-F V-F deleted the bugfix-stack-overflow-in-PdfGraphics2D-translate-method(since-f73467c) branch January 17, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants