New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidsoap doesn't get updated metadata from LibreTime database #618

Open
Robbt opened this Issue Nov 28, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Robbt
Member

Robbt commented Nov 28, 2018

According to this forum post - https://discourse.libretime.org/t/song-metadata-issue/201/2 there is a bug where liquidsoap isn't pulling updated metadata from the libretime database as it purports to here -

def create_liquidsoap_annotation(media):
# We need liq_start_next value in the annotate. That is the value that controls overlap duration of crossfade.
filename = media['dst']
annotation = ('annotate:media_id="%s",liq_start_next="0",liq_fade_in="%s",' + \
'liq_fade_out="%s",liq_cue_in="%s",liq_cue_out="%s",' + \
'schedule_table_id="%s",replay_gain="%s dB"') % \
(media['id'],
float(media['fade_in']) / 1000,
float(media['fade_out']) / 1000,
float(media['cue_in']),
float(media['cue_out']),
media['row_id'],
media['replay_gain'])
# Override the the artist/title that Liquidsoap extracts from a file's metadata
# with the metadata we get from Airtime. (You can modify metadata in Airtime's library,
# which doesn't get saved back to the file.)
if 'metadata' in media:
if 'artist_name' in media['metadata']:
artist_name = media['metadata']['artist_name']
if isinstance(artist_name, str):
annotation += ',artist="%s"' % (artist_name.replace('"', '\\"'))
if 'track_title' in media['metadata']:
track_title = media['metadata']['track_title']
if isinstance(track_title, str):
annotation += ',title="%s"' % (track_title.replace('"', '\\"'))
annotation += ":" + filename
return annotation

So if this isn't working there is a bug somewhere. It could be resolved by saving metadata edits back to libretime as discussed in #526 or in troubleshooting what is happening with the function above. At this point we still need to verify this bug is reproducible because I am not the original reporter.

@hairmare

This comment has been minimized.

Member

hairmare commented Dec 3, 2018

I think this is about pypo not pulling metadata from the web-api if none is available in the actual file (as is the case with wav files). I think I've seen this before but can't find an issue describing it. I'm pretty sure the following line is somehow involved.

stream_queue = map_metadata(update=false, append_title, stream_queue)

At least I think it's where the data ends up being applied in the liquidsoap parts. Seeing how there's not much to it maybe we need to stare at the python parts more to figure this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment