Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Ubuntu 19.10 Eoan Ermine Support #967

Open
wants to merge 5 commits into
base: master
from

Conversation

@kmahelona
Copy link
Contributor

kmahelona commented Mar 3, 2020

I'm not sure if we want this since this isn't an LTS version of Ubuntu but I'm providing this because I do want to work on aac streaming support with liquidsoap ~1.3. and presumably this will make the Ubuntu 20. support easier when that's release.

@paddatrapper

This comment has been minimized.

Copy link
Contributor

paddatrapper commented Mar 4, 2020

I think the more the merrier, so adding 19.10 is a good idea. We just need to deprecate it when upstream support is dropped. libfdkaac-ocaml should add ACC support to liquidsoap. After that it should just be a matter of adding the format to the liquidsoap calls made my LibreTime

@kmahelona

This comment has been minimized.

Copy link
Contributor Author

kmahelona commented Mar 4, 2020

Cool.

Yea I installed libfdkaac-ocaml but still got this error in /var/log/airtime/pypo-liquidsoap/ls_script.log,
[dynamic.loader:3] Error while loading dynamic fdkaac encoder at /usr/lib/ocaml/fdkaac

@paddatrapper

This comment has been minimized.

Copy link
Contributor

paddatrapper commented Mar 4, 2020

Maybe create a forum post and we can debug it?

@kmahelona

This comment has been minimized.

Copy link
Contributor Author

kmahelona commented Mar 9, 2020

Forum post here for discussion: https://discourse.libretime.org/t/ubuntu-19-10-eon-ermine-support/487

More issues possibly with 19.10 and liquidsoap 1.3.7,

[decoder:3] Method "AAC" accepted "audio/aacp".
[http:3] Decoding...
[http:2] Feeding stopped: Faad error: Unexpected channel configuration change

I'm having issues decoding AAC web streams. MP3 web streams are playing fine.

@kmahelona

This comment has been minimized.

Copy link
Contributor Author

kmahelona commented Mar 10, 2020

I've managed to get liquidsoap 1.4.1 built and working in hopes that it would fix my faad error above. It didn't appear to fix it but I also ran into a bunch of other issues where the liquidsoap scripts need to be updated for 1.4.1 and I kinda guessed it and got something that runs but basically can't play files but can now play an aac webstream (I think I broke things with the cross() functions).

In 1.4.1 I still get a bunch of the same errors above but after about 6 of those I get Channel coupling not yet implemented,

[http:2] Feeding stopped: Faad error: Unexpected channel configuration change
[decoder:3] Method "AAC" accepted "audio/aacp".
[http:3] Decoding...
[http:2] Feeding stopped: Faad error: Unexpected channel configuration change
[decoder:3] Method "AAC" accepted "audio/aacp".
[http:3] Decoding...
[http:2] Feeding stopped: Faad error: Channel coupling not yet implemented
[decoder:3] Method "AAC" accepted "audio/aacp".
[http:3] Decoding...

And then it plays the aac stream without error.

I think what I'll try now is to build liquidsoap 1.3.7 using opam and see if that fixes my issues. The liq script aren't the cause of the error as a simple test script just to restream an aac icecast link also gives the same error.

Is anyone else having trouble playing (decoding) aac streams?

@kmahelona

This comment has been minimized.

Copy link
Contributor Author

kmahelona commented Mar 10, 2020

One issue I've found with this version of Ubuntu and liquidsoap is that the faad library used cannot decode HE-AACv2 streams, and it also can't stream AAC (I've had errors even after installing the libfdk libraries).

Other than that I'm able to get Ubuntu 19.10 working fine.

But for the two reasons mentioned above, maybe that's enough to not include support of this version of Ubuntu. We may need to look out for these issues in Ubuntu 20.

@paddatrapper

This comment has been minimized.

Copy link
Contributor

paddatrapper commented Mar 11, 2020

Is it possible to do those two things in Ubuntu 18.04?

@kmahelona

This comment has been minimized.

Copy link
Contributor Author

kmahelona commented Mar 11, 2020

I'm not sure, but I could give it a try if that would be useful. I should probably be using vagrant and then I could test these things much more quickly ;).

@Robbt

This comment has been minimized.

Copy link
Member

Robbt commented Mar 17, 2020

Vagrant is super helpful for development and relatively straight forward to get setup - the manual is on http://libretime.org/vagrant/

In terms of the streaming support this doesn't seem like a good reason to deny support if anything we should open up a separate issue for this and try to isolate the cause and test the streams.

Are there public streams where we can test different versions of LibreTime to see if they support HE-AACv2 ?

I also don't think we have ever support AAC streaming out of the box, this has always required some tweaking to get it working as far as I know see #185

It would be nice to support it but I think it maybe more patent encumbered and less free than other solutions such as opus and/or mp3 (now that the patents for it expired).

@kmahelona

This comment has been minimized.

Copy link
Contributor Author

kmahelona commented Mar 17, 2020

Ok. This pull request is basically ready only I haven't tested the vagrant aspects of it (just didn't get around to it, I do use vagrant for other local dev).

I've got some public HE-AACv2 links that we can use e.g. http://apple.irirangi.net:8000/I_Waatea.aac (and more here: https://github.com/TeHikuMedia/whakaruruhau-website/blob/master/src/assets/radio_streams.ts but please don't do any heavy loading).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.