Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jan 17, 2014
  1. @msaby @gmcharlt

    Bug 11056: Delete dead code in basketgroup.pl

    msaby authored gmcharlt committed
    In basketgroup.pl, some code is supposed to be executed if
    $op = "validate".  But this value is no longer assigned to
    the $op variable since 2009.
    
    This patch suppressed dead code, along with parseinputbaskets
    and parseinputbasketgroups subs, which are obsolete.
    
    No functional changes expected
    
    Regression test :
    * Check basketgroup are shown as before the patch, and can be closed
     and reopened.
    * Check you can add or remove a basket from a basketgroup, and change
      information about it (like delivery place)
    * Check you can create a basketgroup when you close a basket.
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    The following commands return nothing:
    - grep validate acqui/basketgroup.tt
    - grep -R basketgroup.pl -C 2 | grep validate
    - git grep parseinputbaskets
    - git grep parseinputbasketgroups
    - git grep basketgroup.pl | grep validate
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  2. @gmcharlt

    Bug 11138: add auto_unsuspend_holds to daily crontab (Debian package)

    Liz Rea authored gmcharlt committed
    To test:
    
    Install the packages with this patch, observe the /etc/cron.daily/koha-common
    file - auto_unsuspend_holds should now be in the default list.
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  3. @gmcharlt

    Bug 11138 - Add auto_unsuspend_reserves to crontab.example

    Liz Rea authored gmcharlt committed
    To test:
    
    Set up and run the cronjobs from crontab.example with a hold set to
    unsuspend today. The hold should be unsuspended.
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  4. @kfischer @gmcharlt

    Bug 11330: (follow-up) fix description of 951 tag in the default fram…

    kfischer authored gmcharlt committed
    …ework
    
    Fixes one missing for 951 field description in the Default framework.
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  5. @bgkriegel @gmcharlt

    Bug 11330: fix inconsistent field/subfield descriptions on MARC21 bib…

    bgkriegel authored gmcharlt committed
    …liographic frameworks
    
    This patch tries to make MARC21 bibliographic frameworks
    internally consistent. It modifies field/subfield descriptions
    of simple_bib and fastadd frameworks to match corresponding
    ones of default framework.
    
    To test:
    1) Download and edit the attached script, check-diff.sh
    Put on it user, pass and database name of your dev install
    Copy the script on your git home
    
    2) Run the script (bash check-diff.sh).
    WARNING: the script removes bibliographic frameworks, and load
    default, simple_bib and fastadd ones.
    It will show on screen, and write on file differences.txt,
    any difference on field/subfield description (liblibrarian)
    between any framework and default
    
    On master it will show a lot of lines
    
    3) Apply the patch
    
    4) Run the script again. Frameworks files must load without problem.
    There will be no differences
    
    NOTE: There are many "space" changes. The reason
    to that is to format files to ease the translation process.
    Not related with this bug, but necessary.
    Also a few changes on default framework.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
    I ran some tests and found one more case where the
    liblibrarian and libopac columns had slightly different
    descriptions, adding a follow-up for that.
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  6. @mderooy @gmcharlt

    Bug 11329: Check for MARC record existence in catalogue/showmarc

    mderooy authored gmcharlt committed
    Intranet counterpart patch. Same check as in opac/opac-showmarc.
    
    Test plan:
    [1] Run showmarc.pl with valid biblionumber in id parameter.
    [2] Remove id parameter from URL. You should get a 404 now.
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Passes koha-qa.pl, works as advertised.
    
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  7. @mderooy @gmcharlt

    Bug 11329: Check for MARC record existence in opac-showmarc

    mderooy authored gmcharlt committed
    Instead of just running as_formatted, check if GetMarcBiblio returned
    a reference. If you e.g. did not pass an id, return 404 instead of 500.
    Consistent with opac-export.pl
    
    Test plan:
    [1] Run opac-showmarc.pl with valid biblionumber in id parameter.
    [2] Remove id parameter from URL. You should get a 404 now.
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  8. @gmcharlt

    Bug 11237: DBRev 3.15.00.013

    gmcharlt authored
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  9. @joubu @gmcharlt

    Bug 11237: Update default value for pref AcqItemSetSubfieldsWhenReceived

    joubu authored gmcharlt committed
    The default value for this pref should be an empty string, not "0".
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  10. @joubu @gmcharlt

    Bug 11237: Update explanation for pref AcqItemSetSubfieldsWhenReceived

    joubu authored gmcharlt committed
    This patch improves the description of the AcqItemSetSubfieldsWhenReceived
    system preferences to clarify that it applies to updating items
    during order receipt, if those items where created when the order was
    placed.
    
    Test plan:
    Update the updatedb entry and search the pref in the admin module.
    The explanation should have been updated.
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  11. @gmcharlt

    Bug 11363: make units in label printer profile form translatable

    Roman Amor authored gmcharlt committed
    Changed the unit names form an import to a switch case so that it is in
    the .tt so that it can be translated
    
    Signed-off-by: Owen Leonard <oleonard@myacpl.org>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  12. @gmcharlt

    Bug 11477: (follow-up) improve display of user/patrons in logs tool

    gmcharlt authored
    This patch tweaks the display of patron and user names in the logs
    tool so that if a name is present, the patron/user ID that follows
    it is enclosed in parentheses.
    
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  13. @minusdavid @gmcharlt

    Bug 11477 - Add names for librarian and borrowers in the logs

    minusdavid authored gmcharlt committed
    This patch adds the first name and surname of the librarian and the
    user involved in a transaction log, if available.
    
    If neither the firstname or the surname is available, then the 'object'
    number will be prefaced with the 'Member' qualifier.
    
    _TEST PLAN_
    
    0) This patch depends on Bug 11473, so you must apply it first
    
    Before applying this patch (11477):
    1) View the logs.
    2) Note that the Librarian column just has a number
    3) Note that the Object column will just say Member X (where X is a
    number), in the circulation, fines, and patron/member modules.
    
    Apply the patch.
    
    4) Reload the logs (you don't need to make new ones)
    5) Note that the Librarian and Object columns mentioned above now
    have firstname and surname appearing (where available)
    
    Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
    Works as described, passes all tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  14. @gmcharlt

    Bug 11473: (follow-up) ensure link to item is construct correctly

    gmcharlt authored
    This patch adjusts the check on action_logs.info to better detect
    if the event concerns an item.  This fixes a problem where the links
    from log entries on item modifications would, if followed, result
    in internal server errors.
    
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  15. @minusdavid @gmcharlt

    Bug 11473 - add 'biblio' and 'item' to cataloguing logging info

    minusdavid authored gmcharlt committed
    This patch adds the words 'biblio' and 'item' to the 'info'
    of the cataloguing logs which were missing them (such as biblio
    delete, biblio mod, item mod, upload cover image).
    
    This patch also adds 'authority' for authority mod.
    
    _TEST PLAN_
    
    Before applying:
    1) Create/view mods for items, biblios, and authorities.
    2) Create/view biblio deletion
    3) Create/view upload cover image log
    4) Note that none of these contain the words 'biblio','item',or
    'authority' in their "Info" columns.
    
    Apply patch.
    
    5) Repeat steps 1-3
    6) Note that the new logs contain 'biblio','item', and 'authority'
    in their "Info" column, while the past ones don't.
    7) Note also that 'biblio' and 'item' will have 'Biblio' and 'Item'
    appear in their "Object" column for the new logs
    
    Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  16. @minusdavid @gmcharlt

    Bug 11473 - Improve wording in log viewer template

    minusdavid authored gmcharlt committed
    This patch capitalizes 'member' and 'biblio' as object labels in the
    log viewer.
    
    It also adds a "Subscription" label, and changes "auth" to "Authority".
    
    _TEST PLAN_
    
    Before applying patch:
    
    1) View logs for patrons, new biblio, serials, and authorities.
    
    Apply the patch:
    
    1) Notice the capitalization and new/modified labels.
    
    Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  17. @minusdavid @gmcharlt

    Bug 11473 - Remove boilerplate in log viewer template

    minusdavid authored gmcharlt committed
    This patch eliminates unnecessary conditions and boilerplate.
    
    _TEST PLAN_
    
    Apply the patch.
    
    1) Try viewing logs for circulation, patrons, fines,
    cataloguines, serials, authorities, etc.
    2) Note that everything should look exactly the same as before,
    with one exception: FINES
    3) Fines will now show "member X" for the user associated with
    the fine.
    
    Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  18. @minusdavid @gmcharlt

    Bug 11473 - Fix log viewer template conditions

    minusdavid authored gmcharlt committed
    This patch adds the 'loopro' key to the 'module' value, so that
    conditions are actually triggered in the template logic.
    
    (Note: loopro.CIRCULATION is valid, but I changed it for the sake
    of consistency across the different conditions.)
    
    This patch also adds substr checks to the 'info' column when
    using the cataloguing module. This will check for 'item' and 'biblio',
    so that the appropriate label qualifer can be shown in the log viewer.
    If either term is absent, the unqualified number will be shown instead
    (this will be the majority of action logs at this point).
    
    _TEST PLAN_
    
    Before applying:
    
    1) Access log viewer from Tools (or wherever really)
    2) Look up logs for circulation, patrons, cataloguing, serial,
    authorities, etc.
    3) Note that the "Object" will always just be a number without qualification.
    
    After applying the patch:
    
    1) Look at those same logs
    2) Note that the object number for borrowers will usually be prefaced
    by 'member' (notwithstanding FINES which aren't taken into account in
    this template yet); new bibs and new items should say 'Item X' or
    'Biblio X'. Serials should have a link. Authorities should have a link
    and an 'auth' preface.
    
    Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
    
    Works as advertised
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  19. @oleonard @gmcharlt

    Bug 11476: remove extra empty option from title pull-down in OPAC sel…

    oleonard authored gmcharlt committed
    …f-registration
    
    If you have patron titles enabled, the OPAC patron details form lists 2
    empty spaces instead of 1. An empty option is passed by the script, so
    the template does not need to include one.
    
    To test you must have at least one patron title set in BorrowersTitles
    system preference and OPACPatronDetails must be set to "allow."
    
    1. Apply the patch
    2. Log in to the OPAC
    3. Click the "personal details" tab.
    4. Click the "salutation" dropdown. There should be only one blank line
       preceding the existing titles.
    
    Test in both prog and bootstrap.
    
    Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
    Works as described for existing and creating new accounts.
    
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  20. @joubu @gmcharlt

    Bug 11018: allow adding order from a reverted MARC batch

    joubu authored gmcharlt committed
    Weird behavior:
    When an import is undone into catalog, the status is set to "reverted".
    But if you open the add orders from iso2709, the status is automatically
    set to "imported" and does not appear in the list.
    So it is not possible to import a reverted batch.
    
    [RM note: since a reverted batch is nonetheless a staged batch, and
    could be reused, allowing orders to be placed by taking bibs
    from a reverted batch is not as odd as it might sound.  It *can* look
    odd for a staged or reverted batch to contain records that are
    imported, but that's a long-standing oddity.]
    
    Test plan:
    - verify you reproduce the weird behavior
    - apply this patch
    - import a file and the batch into the catalog
    - verify (in the your mysql/MariaDB cli) the status is "imported"
    - verify it does not appears in the add orders from iso2809 page
    - undo the import
    - verify (in the your mysql/MariaDB cli) the status is "reverted"
    - verify it appears in the add orders from iso2809 page and the status
      is always "reverted"
    - finish the order
    
    Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  21. @gmcharlt

    Bug 9788: (follow-up) update the bootstrap theme

    gmcharlt authored
    This patch applies the change made in the QA follow-up
    to the Bootstrap theme.
    
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  22. @mderooy @gmcharlt

    Bug 9788: (follow-up) Unit tests for changed routine GetReservesFromI…

    mderooy authored gmcharlt committed
    …temnumber
    
    Adds three tests to Reserves.t for GetReservesFromItemnumber.
    We test if this routine does not return a future next available hold,
    a future item level hold. And if it does return a future wait (that is:
    a confirmed future hold, using ConfirmFutureHolds).
    
    Note that Holds.t does also contains some basic tests for this routine,
    but the additional tests seem to better located in the direct context of
    tests for bug 9761 for ConfirmFutureHolds.
    
    Test plan:
    Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t.
    Verify if both tests do not fail.
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  23. @joubu @gmcharlt

    Bug 9788: QA followup

    joubu authored gmcharlt committed
    1/ CURRENT_DATE() is a MySQLism and should be replaced with CAST(now() AS
    DATE).
    2/ The date formatting should be done in the template (using the TT
    plugin).
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  24. @mderooy @gmcharlt

    Bug 9788: (follow-up) for expirationdate in Letter.pm

    mderooy authored gmcharlt committed
    Pasting comment from the Bugzilla report:
    
    Looking bit longer at this code, it is kind of strange to find it
    there in the first place. Adding maxpickupdelay in Letters.pm should
    not be there, but it is..
    
    Also this date is not used normally in the default HOLD Available for
    Pickup notice (that we are generating in this case). And if it would be
    undef, the expiration date should imo be empty instead of today+0.
    (before adding maxreservespickupdelay, you should test the allowexpire
    pref first) So it is an (invisible) bug on its own.
    
    Test plan:
    See former patch. Kyle just discovered this bug, apparently by
    deleting the maxpickupdelay pref..
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  25. @mderooy @gmcharlt

    Bug 9788: (follow-up) removing the alldates parameter from GetReserve…

    mderooy authored gmcharlt committed
    …sFromItemnumber
    
    Before bug 9788 the alldates parameter of GetReservesFromItemnumber was
    actually not used in the codebase.
    The first patch of bug 9788 did change that and passed true by default.
    
    But a closer look revealed that we do not really need it.
    
    The parameter is removed by this patch; the SQL statement is slightly
    adjusted: if reservedate<=now or a waitingdate is filled for the
    requested itemnumber, GetReservesFromItemnumber will return the reserve.
    
    This includes so-called future waits: a future hold that has been confirmed
    ahead of time with pref ConfirmFutureHolds > 0 days.
    
    Note that future item-level holds are not really interesting to return; this
    just corresponds to original behavior. Future next-available holds are not
    in view at all; they do not contain an item number.
    
    Test plan:
    Actually, the test plan of the first patch is valid. But for completeness I
    repeat it here:
    
    [1] Enable future holds and set ConfirmFutureHolds to 2 days.
    [2] Place a future next-available hold for 2 days ahead.
    [3] Check item status on catalogue detail. Available? That is fine.
    [4] Confirm the future hold by checking it in. ('future wait')
    [5] Look at item status again on catalogue detail. Must be Waiting now.
    [6] Switch to OPAC and login as another opac user. Goto Place a hold.
    [7] Check item status with item level hold info. Is it waiting?
    [8] Try to place hold in staff, check item level status again. Waiting?
    [9] Make a transfer for the item. Switch branch. Check hold status on
        Transfers to receive.
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  26. @mderooy @gmcharlt

    Bug 9788: Improvements when calling GetReservesFromItemnumber

    mderooy authored gmcharlt committed
    This patch makes GetReservesFromItemnumber also returns the waiting
    date and removes some repeated code.
    
    Improves item status display on catalogue detail, when placing a hold at
    opac-reserve and in staff, and on transfers to receive form.
    
    This patch builds on work from reports 9367 and 9761.
    
    Test plan:
    
    Place a future next-av. hold (enable future holds prefs), say 2 days ahead.
    Check item status on catalogue detail. Nothing to see.
    Enable ConfirmFutureHolds by inserting a number of days, say 2.
    Confirm earlier hold by checking it in. Look at item status again on detail.
    Switch to other opac user. Try to place a hold again. Check item status with
    item level hold info. Try to place hold in staff, check item level status.
    Make a transfer for that item. Switch branch. Look at transfers to receive.
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Commits on Jan 16, 2014
  1. @gmcharlt

    Bug 10987: (follow-up) fix display of authorities containing only one…

    gmcharlt authored
    … see from or see also lnik
    
    This patch fixes an incorrect test on the number of see from and
    see also links in the authority record, as otherwise if a record
    had only one 4XX or 5XX, the linked headings weren't displayed at
    all.  This patch also makes the test consistent across the staff
    theme and the two OPAC themes.
    
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  2. @tomascohen @gmcharlt

    Bug 10987: remove duplicate 'see also' and 'see from' labels from aut…

    tomascohen authored gmcharlt committed
    …hority search results
    
    If an authority record has more than one 4xx$a (or 5xx$a) entries the
    corresponding labels 'see also' and 'used for/see from' werwe repeated.
    This patch removes duplicate instances of the labels, improving
    readability.
    
    To test:
    - Have authority records with more than one entry on the 4xx (or 5xx)
      fields.
    - Do a search, check "see also:" (or 'used for/see from') appear more
      than once.
    - Apply the patch
    - Reload and check it looks nicer :-D
    - Repeat for: staff auth search, OPAC using ccsr, OPAC using prog
    - Signoff
    
    Sponsored-by: Universidad Nacional de Cordoba
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    
    Work as decribed. No koha-qa errors
    Nice view on staff and both opac
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  3. @gmcharlt

    Bug 10691: (follow-up) replace HTML comments with TT contents

    gmcharlt authored
    Comments on the usage of Template Toolkit blocks don't need
    to appear in the rendered HTML, so this patch converts HTML
    comments to TT comments and thereby saves a tiny amount of
    bandwidth.
    
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  4. @tomascohen @gmcharlt

    Bug 10691: (follow-up) restore behaviour for control field ($w)

    tomascohen authored gmcharlt committed
    As noted by Jared, in the presence of 4XX$w or 5XX$w the display
    got broken by this refactoring. This patch restores the previous
    behaviour in that front.
    
    The OPAC themes get fixed too, and the Bootstrap one gets this
    fix too.
    
    Applied the fix that Galen proposed on comment #30 regarding
    Zeno's fix in bug 11174.
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  5. @tomascohen @gmcharlt

    Bug 10691: use authority ID in see-also links in authority search res…

    tomascohen authored gmcharlt committed
    …ults (OPAC)
    
    This patch changes the URL and data used to show the 'see also' links
    on the OPAC's authority search results page.
    
    Bonus points: makes some strings translatable.
    
    To test:
    - On your dev setup (master) create some authority records (I created
      personal name authorities).
    - Pick one of them and link 400$a to another one, do the same with 500$a
    - Add some other 400$a and 500$a without linking (i.e. plain text)
    - Make sure zebra is running and changes got indexed.
    - In the OPAC search for the authority that is linked to the others.
    - Check the 'see also:' link points to an authority search
    - Apply the patch
    - Reload/re-do the search
    - Check the 'see also:' link points to the authority id in the case
      of linked authorities, and to an authority search in the case of
      plain text headings.
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    
    Work as described. No errors
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  6. @tomascohen @gmcharlt

    Bug 10691: use authority ID in see-also links in authority search res…

    tomascohen authored gmcharlt committed
    …ults (staff)
    
    This patch changes the URL and data used to show the 'see also' links
    on the Staff's authority search results page.
    
    Bonus points: makes some strings translatable.
    
    To test:
    - On your dev setup (master) create some authority records (I created
      personal name authorities).
    - Pick one of them and link 400$a to another one, do the same with 500$a
    - Add some other 400$a and 500$a entries with plain text (i.e. no
      linking)
    - Make sure zebra is running and changes got indexed.
    - In the staff interface search for the authority that is linked to the
      others.
    - Check the 'see also:' link points to an authority search
    - Apply the patch
    - Reload/re-do the search
    - Check the 'see also:' link points to the authority id for linked
      authorities,
      and to an authority search result in the case of plain text entries.
    - Check that the authority search from the cataloguing interface still
      works as usual.
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
    
    Work as described. No errors
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  7. @gmcharlt

    Bug 7143: add another name to the about page

    gmcharlt authored
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
  8. @ranginui @gmcharlt

    Bug 7143: Updating about page and history

    ranginui authored gmcharlt committed
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Commits on Jan 15, 2014
  1. @joubu @gmcharlt

    Bug 11543: (followup) add one more test

    joubu authored gmcharlt committed
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
    Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Something went wrong with that request. Please try again.