Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mail failure alert #237

Merged
merged 9 commits into from Nov 13, 2017

Conversation

@grantjbutler
Copy link
Contributor

grantjbutler commented Nov 9, 2017

This brings the changes for #220 into master, with one code change to fix a variable reference. The original body of PR #220 is reproduced below for reference.


Closes #219.

What It Does

Previously, if the user clicked Send and the MailSender experienced a failure (e.g. when there are no mail accounts set up), nothing would happen in the GUI. There was also no method in PinpointKitDelegate to correspond to didFailToSend in SenderDelegate.

This commit adds an alert popup to PinpointKit to solve the first problem, and a didFailToSend method to PinpointKitDelegate for the second. The latter takes the original Error as a parameter in case developers want to use it present more specific messages.

simulator

How to Test

Ensure that the mailer will encounter an error (the easiest way is to run the example app on a simulator with no email accounts set up) and click Send.

Notes

None in particular.

SpencerMichaels and others added 7 commits May 13, 2017
Added GUI alert on mailer failure.
@grantjbutler grantjbutler requested a review from mattbischoff Nov 9, 2017
@mattbischoff

This comment has been minimized.

Copy link
Member

mattbischoff commented Nov 13, 2017

@grantjbutler Merge when Buddybuild finished.

@grantjbutler grantjbutler merged commit d54382f into master Nov 13, 2017
1 check passed
1 check passed
buddybuild: PinpointKit (iOS, PinpointKit - Debug) Build succeeded
Details
@grantjbutler grantjbutler deleted the add-mail-failure-alert branch Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.