Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom Shell #1756

Merged
merged 106 commits into from Jul 2, 2015
Merged

Atom Shell #1756

merged 106 commits into from Jul 2, 2015

Conversation

@MikeInnes
Copy link
Contributor

MikeInnes commented Nov 30, 2014

Figured I'd turn Chris's work on #1728 into a PR so we can all discuss what needs doing and make changes. Feel free to edit this with new tasks.

  • Sort out inconsistencies with quitting (Atom, at least on OS X, distinguishes between closing windows and quitting).
  • Porting CLI
    • drag/drop opening
    • open files
    • open from file manager during and after startup
  • Save and restore window position
  • Previous workspace isn't loading on startup
  • Windows Testing
  • Linux Testing
  • Packaging Build Step
  • Port nw package.json options to atom-shell. References: nw options and browser-window options
    • Figure out why icon option doesn't work
  • Sort out JS loading (JQuery isn't working for me any more)
  • Keybinding issues
    • Esc doesn't work in command bar
  • Resolve error loading node modules when pwd is not the app directory
  • File save dialogs are broken
  • Project search leaves working indicator on (ok, my workspace is just really huge)
  • Julia plugin
    • Interactive plots broken
  • platform/open no worky
  • Binary and app updates
  • script/build.sh (to replace *_deps.sh)
    • build on osx and functions correctly
    • clone plugins
    • copy over executables e.g. light
    • handle plugins/node/node{,.exe}
    • rename app - may need to workaround this issue on osx
    • git add and use relevant contents of zip files
      • Mac: port plist
    • osx issues: console printing is wonky, icon doesn't show up, initial focus is inconsistent
    • build on linux - done on 64bit ubuntu 14.04
    • build on windows - done on 32 bit windows 7
  • mac menu issues: Select All and Cut don't work. This issue also exists with node-webkit and only happens when vim is enabled.
  • Port proxy support (we don't have a way to test this)
  • Evaling into browser tabs
  • Windows issues
    • cursor issues (doesn't change when resizing tabs) - not observed in windows 7
    • closing last window doesn't close app
    • opening file from cygwin terminal doesn't work
  • Linux issues
    • opening files from commandline doesn't work
    • worker syntax error - not observed in ubuntu 14
  • Updates to LT should be driven by main.js so that they can be guaranteed to only happen once

Install Instructions:
See doc/developer-install.md for full instructions

For OSX:

$ script/build.sh
# open from commandline
$ builds/lighttable-0.8.0-mac/light
# OR open executable
$ open -a $PWD/builds/lighttable-0.8.0-mac/LightTable.app

For Linux:

$ script/build.sh
# open from commandline
$ builds/lighttable-0.8.0-linux/light
# OR open executable
$ open -a $PWD/builds/lighttable-0.8.0-linux/LightTable

For Windows:

$ script/build.sh
# open executable
$ builds/lighttable-0.8.0-windows/LightTable.exe
@ibdknox
Copy link
Member

ibdknox commented Nov 30, 2014

added more tasks in there.

@cldwalker
Copy link
Member

cldwalker commented Dec 2, 2014

Ported most of the nw package.json options. Doc links in above task.
@ibdknox I didn't see equivalents for js-flags, some of the chromium-args, no-edit-menu or toolbar but perhaps you may recognize their equivalents

@ibdknox
Copy link
Member

ibdknox commented Dec 2, 2014

@cldwalker I think there's an API for reading the package.json that is provided by the atom-shell. The missing things shouldn't matter anymore except for maybe one or two of the chromium-args. Threaded-compositing used to cause all sorts of issues.

@MikeInnes
Copy link
Contributor Author

MikeInnes commented Dec 8, 2014

Interestingly, atom-shell seems to change the results of fuzzy searching. I used to be able to type rwi to reset the working indicator.

@ibdknox Any ideas why this might be? It's not an issue as-is, but just in case it points to something deeper

@MikeInnes
Copy link
Contributor Author

MikeInnes commented Dec 8, 2014

With the relative path fixes you can now run ./deploy/run.sh &, which is a bit more convenient (for me at least).

@MikeInnes MikeInnes force-pushed the atom-shell branch from 231744e to 805da5e Dec 10, 2014
ibdknox and others added 6 commits Mar 23, 2015
Signed-off-by: Chris Granger <ibdknox@gmail.com>
Signed-off-by: Chris Granger <ibdknox@gmail.com>
Github has changed the name of atom-shell to electron as per
electron/electron#1389
It seems though that the download-electron grunt task seems to create an
Atom.app package. Was expecting it to be Electron.app and raised an issue
for them here electron-archive/grunt-download-electron#30

NOTE: I haven't tested this on Linux or Windows
@kenny-evitt
Copy link
Contributor

kenny-evitt commented May 28, 2015

@one-more-minute it seems like the "Windows issues" and "Linux issues" checklist items should be considered complete too. I'm having trouble building on Windows myself but otherwise I think we should consider this done.

I think we should punt on proxy support for now.

I'm not sure about the last item – "Updates to LT should be driven by main.js so that they can be guaranteed to only happen once". Given the existing comments for this, I think we should punt on this for now too.

@cldwalker @ibdknox @one-more-minute – if possible, it would be great if builds could be released as an alpha version for the rest of the community to test.

@kenny-evitt

This comment has been minimized.

Copy link
Contributor Author

kenny-evitt commented on 7d53886 Jun 14, 2015

See #1918

@kenny-evitt

This comment has been minimized.

Copy link
Contributor Author

kenny-evitt commented on b468d5d Jun 14, 2015

See #1918

kenny-evitt added 2 commits Jun 14, 2015
Update build scripts for atom-shell name change to electron
Electron name change: update for Linux references
@kenny-evitt
Copy link
Contributor

kenny-evitt commented Jun 14, 2015

@cldwalker @ibdknox @one-more-minute @joshuafcole @rundis

There are two items not marked complete:

  • Port proxy support (we don't have a way to test this)
  • Updates to LT should be driven by main.js so that they can be guaranteed to only happen once

Can we defer completing them before creating a new release? Can defer them for a beta release?

rundis and others added 8 commits Jun 16, 2015
Fix buildscript for mac app still called Atom.app not Electron.app
…es-to-disable-git-autocrlf

Add Git attributes file to disable auto-CRLF conversion for all text files.
Added pre-condition section for Linux build on atom-shell
Fix #1929
Quotes `pwd` to support spaces in path
kenny-evitt added a commit that referenced this pull request Jul 2, 2015
Migrate from node-webkit to Atom Shell (Electron).
@kenny-evitt kenny-evitt merged commit 8b9b4c9 into master Jul 2, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rundis

This comment has been minimized.

Copy link
Contributor

rundis commented on project.clj in 8e73f59 Jul 15, 2015

@ibdknox Where does this version originate from, what source was used to build it ?

@kenny-evitt kenny-evitt deleted the atom-shell branch Sep 28, 2015
@TheInitializer
Copy link

TheInitializer commented Nov 4, 2015

is there a way to port it back to nw? The performance is generally a lot better there

@kenny-evitt
Copy link
Contributor

kenny-evitt commented Nov 4, 2015

@TheInitializer No need; just use an old version (there's a recent issue with the links). Or fork the code prior to the merge of this the atom-shell branch. I'm not interested in maintaining two versions of the app, nor do I suspect are any of the other commiters or contributors. But I can offer tentative, sporadic, and minimal help for anyone that is so interested.

@rundis

This comment has been minimized.

Copy link
Contributor

rundis commented on deploy/core/node_modules/bencode/lib/decode.js in d951744 Jan 5, 2016

@ibdknox Do you remember why this fix was added ? I tried replacing the bencode module with the latest version (0.7.0) from npm. Couldn't notice any difference, however I guess this fix was made for a reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.