Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Atom Shell #1756
Figured I'd turn Chris's work on #1728 into a PR so we can all discuss what needs doing and make changes. Feel free to edit this with new tasks.
$ script/build.sh # open from commandline $ builds/lighttable-0.8.0-mac/light # OR open executable $ open -a $PWD/builds/lighttable-0.8.0-mac/LightTable.app
$ script/build.sh # open from commandline $ builds/lighttable-0.8.0-linux/light # OR open executable $ open -a $PWD/builds/lighttable-0.8.0-linux/LightTable
$ script/build.sh # open executable $ builds/lighttable-0.8.0-windows/LightTable.exe
@one-more-minute it seems like the "Windows issues" and "Linux issues" checklist items should be considered complete too. I'm having trouble building on Windows myself but otherwise I think we should consider this done.
I think we should punt on proxy support for now.
I'm not sure about the last item – "Updates to LT should be driven by main.js so that they can be guaranteed to only happen once". Given the existing comments for this, I think we should punt on this for now too.
There are two items not marked complete:
Can we defer completing them before creating a new release? Can defer them for a beta release?
…es-to-disable-git-autocrlf Add Git attributes file to disable auto-CRLF conversion for all text files.
@TheInitializer No need; just use an old version (there's a recent issue with the links). Or fork the code prior to the merge of this the atom-shell branch. I'm not interested in maintaining two versions of the app, nor do I suspect are any of the other commiters or contributors. But I can offer tentative, sporadic, and minimal help for anyone that is so interested.
Jan 5, 2016
@ibdknox Do you remember why this fix was added ? I tried replacing the bencode module with the latest version (0.7.0) from npm. Couldn't notice any difference, however I guess this fix was made for a reason.