Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Atom Shell #1756
Figured I'd turn Chris's work on #1728 into a PR so we can all discuss what needs doing and make changes. Feel free to edit this with new tasks.
$ script/build.sh # open from commandline $ builds/lighttable-0.8.0-mac/light # OR open executable $ open -a $PWD/builds/lighttable-0.8.0-mac/LightTable.app
$ script/build.sh # open from commandline $ builds/lighttable-0.8.0-linux/light # OR open executable $ open -a $PWD/builds/lighttable-0.8.0-linux/LightTable
$ script/build.sh # open executable $ builds/lighttable-0.8.0-windows/LightTable.exe
referenced this pull request
Dec 6, 2014
It's great to see we're upgrading cljs. I'm noticing some quirks around the upgrade:
I'll look into this last issue some more.
Yeah I noticed the weirdness too. I'm going to upgrade the clojure plugin's cljs and see if that fixes it. My thought is that if we're already making a fairly scary change that's going to break compatibility we should probably do all of them at once. :( Better to rip the bandaid off and fix everything in one go as opposed to constantly requiring people to update their plugins. I'll start a thread about it to see if that's consensus.
I just compile this:
With optimizations :simple and take the resulting output.
From code reading:
We need the compiled clojurescript in order to run clojurescript code in the background thread. As for the two dependencies, I think only cljs.reader is used but I could be wrong
Is this going to stay free forever or should we start forking?…
On Mar 15, 2015 6:24 PM, "Chris Granger" ***@***.*** wrote: My fixes here were hacks that didn't really work. The next release of atom-shell has this fixed for real. — Reply to this email directly or view it on GitHub da556af#commitcomment-10205372 .
@one-more-minute it seems like the "Windows issues" and "Linux issues" checklist items should be considered complete too. I'm having trouble building on Windows myself but otherwise I think we should consider this done.
I think we should punt on proxy support for now.
I'm not sure about the last item – "Updates to LT should be driven by main.js so that they can be guaranteed to only happen once". Given the existing comments for this, I think we should punt on this for now too.
There are two items not marked complete:
Can we defer completing them before creating a new release? Can defer them for a beta release?
added a commit
this pull request
Jul 2, 2015
@TheInitializer No need; just use an old version (there's a recent issue with the links). Or fork the code prior to the merge of this the atom-shell branch. I'm not interested in maintaining two versions of the app, nor do I suspect are any of the other commiters or contributors. But I can offer tentative, sporadic, and minimal help for anyone that is so interested.
Jan 5, 2016
@ibdknox Do you remember why this fix was added ? I tried replacing the bencode module with the latest version (0.7.0) from npm. Couldn't notice any difference, however I guess this fix was made for a reason.