Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback function promise should be optional #3

Merged
merged 1 commit into from May 13, 2016

Conversation

@martynchamberlin
Copy link

martynchamberlin commented May 12, 2016

Once the user has lazy loaded all of the available content from the database, the front-end should no longer continue sending HTTP requests for further pagination. Without an HTTP request, no promise is returned, unless we return a fake $q.defer().promise object like this:

var deferred = $q.defer();
deferred.resolve();
return deferred.promise;

That is superfluous though, compared with simply not having this promise as a requirement.

@LightZam

This comment has been minimized.

Copy link
Owner

LightZam commented May 13, 2016

it looks awesome, thank you.

@LightZam LightZam merged commit 7bd0da9 into LightZam:master May 13, 2016
@martynchamberlin

This comment has been minimized.

Copy link
Author

martynchamberlin commented May 13, 2016

@LightZam Awesome, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.