Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify several profile calls #11031

Merged

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Dec 10, 2021

What does this PR do?

Remove several calls to profiler.profile in favor doing the profiling inside trainer._call_ttp_hook

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

pytorch_lightning/core/optimizer.py Outdated Show resolved Hide resolved
@carmocca carmocca added this to the 1.6 milestone Dec 13, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 13, 2021
@daniellepintz daniellepintz enabled auto-merge (squash) December 14, 2021 19:20
@daniellepintz daniellepintz merged commit 06c5903 into Lightning-AI:master Dec 14, 2021
@daniellepintz daniellepintz deleted the simplify_profile_refs branch December 14, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiler ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants