Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using any Sampler in distributed environment in Lite #13646

Merged
merged 2 commits into from Jul 14, 2022

Conversation

otaj
Copy link
Contributor

@otaj otaj commented Jul 14, 2022

What does this PR do?

Since we merged #12959, there is no need to block usage of any sampler in distributed environment. This PR removes this restriction from lite

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @Borda @awaelchli @rohitgr7 @akihironitta @justusschock @ninginthecloud @otaj @carmocca

@otaj otaj added data handling Generic data-related topic fabric lightning.fabric.Fabric labels Jul 14, 2022
@otaj otaj added this to the pl:1.6.x milestone Jul 14, 2022
@otaj otaj self-assigned this Jul 14, 2022
@otaj otaj added the distributed Generic distributed-related topic label Jul 14, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added the ready PRs ready to be merged label Jul 14, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat !

@otaj otaj enabled auto-merge (squash) July 14, 2022 11:03
@otaj otaj merged commit 9098514 into master Jul 14, 2022
@otaj otaj deleted the bugfix/lift_sampler_lite_requirement branch July 14, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data handling Generic data-related topic distributed Generic distributed-related topic fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants