Upgrade CI to PyTorch 1.13 #15403

Borda · 2022-10-28T21:38:30Z

What does this PR do?

Dropping PT 1.13 from RC and use is as latest

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

Borda · 2022-10-31T17:09:14Z

@kaushikb11, are we aware of this Bagua limitation?

#12 0.700 ERROR: Could not find a version that satisfies the requirement bagua-cuda116 (from versions: none)
#12 0.700 ERROR: No matching distribution found for bagua-cuda116

.github/checkgroup.yml

.github/workflows/ci-pytorch-tests.yml

carmocca

LGTM. Lite and PyTorch CPU configs now match

carmocca · 2022-11-12T21:11:53Z

Test PyTorch / pl-cpu (macOS-11, pytorch, 3.7, 1.10, oldest) is consistently hanging. We weren't testing this combination before. I suggest we just drop it and move on.

(Trying one last time by merging master)

Borda · 2022-11-12T21:48:10Z

I suggest we just drop it and move on.

I am fine with drop :)

lantiga · 2022-11-12T21:49:43Z

100% drop!

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> (cherry picked from commit 57ac548)

* chlog update * mypy: ignore mypy serve (#15631) (cherry picked from commit 38f2a91) * Enable Probot CheckGroup v3 (#15622) (cherry picked from commit bd870c6) * [App] Enable state broadcast with MultiNode (#15607) (cherry picked from commit 61c1f69) * [App] Resolve race condition to move ui files (#15398) (cherry picked from commit 2f0c039) * Make sure save_dir can be empty str (#15638) (cherry picked from commit c53dc20) * [App] Resolve bi-directional queue bug (#15642) (cherry picked from commit 0250c19) * Refactor checkgroup to avoid duplicated checks (#15633) Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit 1954764) * Delete unused TPU CI files (#15611) Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit a3edbec) * Update run_ptl_script.py (cherry picked from commit 4e8cf85) * [App] Accelerate Multi Node Startup Time (#15650) (cherry picked from commit 757413c) * [App] Change app root / config path to be the `app.py` parent directory (#15654) * Change app root / config path to be the `app.py` parent directory * Update CHANGELOG.md * mypy * Fix * Mypy (cherry picked from commit b3281eb) * Add LightningLite to top level imports (#15502) Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> (cherry picked from commit c32c435) * Upgrade GPU CI to PyTorch 1.13 (#15583) Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> (cherry picked from commit e87c11a) * Prevent artifactual "running from outside your current environment" error (#15647) Prevent warning when shutil.executable returns a symlink Co-authored-by: Luca Antiga <luca@lightning.ai> (cherry picked from commit 3248f33) * Fix ddp_spawn -> ddp fallback logic when on LSF cluster (#15657) Co-authored-by: awaelchli <aedu.waelchli@gmail.com> (cherry picked from commit cdb7006) * Include images with the mirror package (#15659) Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> (cherry picked from commit c06ea41) * [App] Rename failed -> error in tables (#15608) Co-authored-by: Raphael Randschau <nicolai86@users.noreply.github.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> (cherry picked from commit ca83b50) * Improves the PanelFrontend docs (#14493) Co-authored-by: Marc Skov Madsen <masma@orsted.dk> Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Felonious-Spellfire <felonious.spellfire@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Mansy <ahmed.mansy156@gmail.com> (cherry picked from commit 10a4b24) * add title and description to ServeGradio (#15639) * add title and description * update test * apply suggestions Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> (cherry picked from commit f9d906c) * Upgrade CI to PyTorch 1.13 (#15403) Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> (cherry picked from commit 57ac548) * Fixed Import in Docs For Multinode Trainer Name Which does Not Exist (#15663) (cherry picked from commit 23f88cd) * Validate the combination of CloudCompute and BuildConfig (#14929) Co-authored-by: otaj <6065855+otaj@users.noreply.github.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> (cherry picked from commit e5a865c) * add contributing guide to readme (cherry picked from commit 98af2bb) * Add Python 3.10 badge (#15681) (cherry picked from commit 8f44bb5) * fix(docs/app): broken links in the intermediate/web-ui section (#15691) (cherry picked from commit 4837df4) * Bump google-github-actions/setup-gcloud from 0 to 1 (#15671) Bumps [google-github-actions/setup-gcloud](https://github.com/google-github-actions/setup-gcloud) from 0 to 1. - [Release notes](https://github.com/google-github-actions/setup-gcloud/releases) - [Changelog](https://github.com/google-github-actions/setup-gcloud/blob/main/CHANGELOG.md) - [Commits](google-github-actions/setup-gcloud@v0...v1) --- updated-dependencies: - dependency-name: google-github-actions/setup-gcloud dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit c451288) * Update onnxruntime requirement from <1.13.0 to <1.14.0 in /requirements (#15672) Updates the requirements on [onnxruntime](https://github.com/microsoft/onnxruntime) to permit the latest version. - [Release notes](https://github.com/microsoft/onnxruntime/releases) - [Changelog](https://github.com/microsoft/onnxruntime/blob/main/docs/ReleaseManagement.md) - [Commits](microsoft/onnxruntime@v0.1.4...v1.13.1) --- updated-dependencies: - dependency-name: onnxruntime dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 7a8e2e9) * Bump google-github-actions/auth from 0 to 1 (#15675) Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 0 to 1. - [Release notes](https://github.com/google-github-actions/auth/releases) - [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md) - [Commits](google-github-actions/auth@v0...v1) --- updated-dependencies: - dependency-name: google-github-actions/auth dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit e93c649) * Docs: Fix import for scikit in XGBoost template (#15693) (cherry picked from commit 9670fa8) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Enable Probot CheckGroup v4 (#15649) (cherry picked from commit 80e7538) * docs 5/n (#15669) * examples * fix few examples * Update pl_multinode.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 41f1a36) * fix(docs/app/lit_tabs): remove unused app_id, enable run instead (#15702) (cherry picked from commit befd3f6) * [App] Mock missing package imports when launching in the cloud (#15711) Co-authored-by: manskx <ahmed.mansy156@gmail.com> (cherry picked from commit f57160b) * Fix catimage import (#15712) (cherry picked from commit ee517f3) * Parse all lines in app file looking for shebangs to run commands. (#15714) fixed command parsing so that all lines in the file are parsed (cherry picked from commit 98bcb3d) * Bump coverage from 6.4.2 to 6.5.0 in /requirements (#15674) Bumps [coverage](https://github.com/nedbat/coveragepy) from 6.4.2 to 6.5.0. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@6.4.2...6.5.0) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 13eb2a1) * remove unused random_split import from tutorial (#15716) (cherry picked from commit b40ca0e) * Fix typo 'wether' (#15710) (cherry picked from commit 609b258) * releasing 1.8.2 Co-authored-by: Ethan Harris <ethanwharris@gmail.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: Tianshu Wang <wang@tianshu.me> Co-authored-by: William Falcon <waf2107@columbia.edu> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Luca Antiga <luca.antiga@gmail.com> Co-authored-by: Atharva Phatak <athp456@gmail.com> Co-authored-by: Luca Furst <rlfurst@gmail.com> Co-authored-by: Marc Skov Madsen <marc.skov.madsen@gmail.com> Co-authored-by: Aniket Maurya <theaniketmaurya@gmail.com> Co-authored-by: Rick Izzo <rlizzo@users.noreply.github.com> Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com> Co-authored-by: 罗崚骁(LUO Lingxiao) <function2-llx@outlook.com> Co-authored-by: Yurij Mikhalevich <yurij@grid.ai> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nash <nash@lightning.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: yiftachbeer <yiftach.beer@gmail.com> Co-authored-by: dymil <30931139+dymil@users.noreply.github.com>

Borda added 4 commits October 28, 2022 23:29

requirements

cff2e96

bump CI

2874b8f

cleaning

970d922

group-check

9feaac9

Borda requested review from tchaton, manskx, lantiga, carmocca, akihironitta, otaj, williamFalcon, awaelchli, kaushikb11 and rohitgr7 as code owners October 28, 2022 21:38

Borda mentioned this pull request Oct 28, 2022

Drop PyTorch 1.9 support #15347

Merged

10 tasks

Borda added this to the v1.8.x milestone Oct 28, 2022

Borda added the ci Continuous Integration label Oct 28, 2022

Borda enabled auto-merge (squash) October 28, 2022 21:46

docker

6cb882a

awaelchli approved these changes Oct 31, 2022

View reviewed changes

if

6b37f1f

mergify bot added the has conflicts label Oct 31, 2022

Merge branch 'master' into ci/pt-1.13

074eb0b

mergify bot removed the has conflicts label Nov 1, 2022

Merge branch 'master' into ci/pt-1.13

d6dedae

otaj reviewed Nov 1, 2022

View reviewed changes

.github/checkgroup.yml Outdated Show resolved Hide resolved

.github/workflows/ci-pytorch-tests.yml Show resolved Hide resolved

Borda requested a review from otaj November 1, 2022 15:02

Borda added 2 commits November 1, 2022 23:25

Merge branch 'master' into ci/pt-1.13

be1bfc7

update

d83eab7

carmocca and others added 4 commits November 11, 2022 21:17

Merge branch 'master' into ci/pt-1.13

37d0d62

Remove stale comments

b8638c7

Merge branch 'master' into ci/pt-1.13

8f3d2c2

Merge branch 'master' into ci/pt-1.13

39a9a43

carmocca changed the title ~~CI/PKG: update to run with PT 1.13~~ Upgrade CI to PyTorch 1.13 #15583 Nov 12, 2022

carmocca removed the admin Requires admin privileges to merge label Nov 12, 2022

carmocca unassigned akihironitta Nov 12, 2022

mergify bot added the has conflicts label Nov 12, 2022

Merge branch 'master' into ci/pt-1.13

ea56ffc

mergify bot removed the has conflicts label Nov 12, 2022

carmocca added 4 commits November 12, 2022 16:05

Unused changes

6a52596

Fix Lite tests according to current checkgroup config

60a2701

Match PL tests config (+SLOW) to Lite test config

1ad9c2a

TODO

98bc516

carmocca approved these changes Nov 12, 2022

View reviewed changes

mergify bot added the ready PRs ready to be merged label Nov 12, 2022

awaelchli approved these changes Nov 12, 2022

View reviewed changes

Merge branch 'master' into ci/pt-1.13

bb94f8a

carmocca enabled auto-merge (squash) November 12, 2022 21:13

carmocca changed the title ~~Upgrade CI to PyTorch 1.13 #15583~~ Upgrade CI to PyTorch 1.13 Nov 12, 2022

carmocca disabled auto-merge November 12, 2022 21:13

carmocca enabled auto-merge (squash) November 12, 2022 21:13

Try 3.8

89601fb

carmocca merged commit 57ac548 into master Nov 12, 2022

carmocca deleted the ci/pt-1.13 branch November 12, 2022 23:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade CI to PyTorch 1.13 #15403

Upgrade CI to PyTorch 1.13 #15403

Borda commented Oct 28, 2022 •

edited by github-actions bot

Borda commented Oct 31, 2022

carmocca left a comment

carmocca commented Nov 12, 2022 •

edited

Borda commented Nov 12, 2022 •

edited

lantiga commented Nov 12, 2022

Upgrade CI to PyTorch 1.13 #15403

Upgrade CI to PyTorch 1.13 #15403

Conversation

Borda commented Oct 28, 2022 • edited by github-actions bot

What does this PR do?

Before submitting

PR review

Did you have fun?

Borda commented Oct 31, 2022

carmocca left a comment

Choose a reason for hiding this comment

carmocca commented Nov 12, 2022 • edited

Borda commented Nov 12, 2022 • edited

lantiga commented Nov 12, 2022

Borda commented Oct 28, 2022 •

edited by github-actions bot

carmocca commented Nov 12, 2022 •

edited

Borda commented Nov 12, 2022 •

edited