Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ethan as Lightning App CodeOwners #15626

Merged
merged 1 commit into from Nov 10, 2022
Merged

Add Ethan as Lightning App CodeOwners #15626

merged 1 commit into from Nov 10, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 10, 2022

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@tchaton tchaton self-assigned this Nov 10, 2022
@tchaton tchaton added the app Generic label for Lightning App package label Nov 10, 2022
@tchaton tchaton added this to the v1.8.x milestone Nov 10, 2022
@lexierule lexierule merged commit 61d3253 into master Nov 10, 2022
13 of 14 checks passed
@lexierule lexierule deleted the add_ethan branch November 10, 2022 18:39
Borda pushed a commit that referenced this pull request Nov 10, 2022
lexierule pushed a commit that referenced this pull request Nov 10, 2022
carmocca pushed a commit to carmocca/lightning that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Generic label for Lightning App package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants