Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pypi pkg #15629

Merged
merged 1 commit into from Nov 10, 2022
Merged

fix pypi pkg #15629

merged 1 commit into from Nov 10, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 10, 2022

What does this PR do?

fix package creations

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @carmocca @akihironitta @Borda

@Borda Borda added this to the v1.8.x milestone Nov 10, 2022
@Borda Borda requested review from narJH27 and rlizzo November 10, 2022 20:20
@Borda Borda added the ci Continuous Integration label Nov 10, 2022
rlizzo
rlizzo approved these changes Nov 10, 2022
@mergify mergify bot added the ready PRs ready to be merged label Nov 10, 2022
@Borda Borda merged commit 18c587e into release/stable Nov 10, 2022
14 of 15 checks passed
@Borda Borda deleted the ci/pypi branch November 10, 2022 20:24
@Borda Borda restored the ci/pypi branch November 10, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants