Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify names in Utils #5199

Merged
merged 11 commits into from Dec 21, 2020
Merged

Unify names in Utils #5199

merged 11 commits into from Dec 21, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 20, 2020

What does this PR do?

Unify the mean utils aka one was exceptions other warning_utils

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the refactor label Dec 20, 2020
@Borda Borda added this to the 1.2 milestone Dec 20, 2020
@Borda Borda added this to In progress in Code Health via automation Dec 20, 2020
@Borda Borda changed the base branch from master to release/1.2-dev December 20, 2020 07:48
@Borda Borda marked this pull request as ready for review December 20, 2020 07:54
@Borda Borda changed the title Refactor: Unify names in Utils Unify names in Utils Dec 20, 2020
@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #5199 (38c7cb4) into release/1.2-dev (0f36525) will decrease coverage by 1%.
The diff coverage is 90%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5199    +/-   ##
================================================
- Coverage               93%     92%    -1%     
================================================
  Files                  134     140     +6     
  Lines                 9897   10163   +266     
================================================
+ Hits                  9196    9319   +123     
- Misses                 701     844   +143     

@Borda Borda added the ready PRs ready to be merged label Dec 21, 2020
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you change something in the files? I think they should show up as renamed/moved without a large diff display

Code Health automation moved this from In progress to Reviewer approved Dec 21, 2020
@Borda
Copy link
Member Author

Borda commented Dec 21, 2020

did you change something in the files? I think they should show up as renamed/moved without a large diff display

no, the content is untouched...

@Borda Borda requested a review from rohitgr7 December 21, 2020 23:23
@Borda Borda merged commit a884866 into release/1.2-dev Dec 21, 2020
Code Health automation moved this from Reviewer approved to Done Dec 21, 2020
@Borda Borda deleted the refactor/utils-name branch December 21, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants