Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecation of gpu string parsing behavior #8770

Merged
merged 4 commits into from Aug 6, 2021
Merged

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Aug 6, 2021

What does this PR do?

I introduced this change in behavior in 1.2.
The deprecation window is now over and we parse strings for --gpus N as the number of devices to use and no longer the index of GPU to use.

To emphasize, this inconsistency only applied when gpus was a string.

Does your PR introduce any breaking changes? If yes, please list them.

YES.

Before 1.5:
trainer = Trainer(gpus="2") selects the 3rd gpu (index 2)
Now:
trainer = Trainer(gpus="2") selects the two first available GPUs (0, 1) and is consistent with gpus=int.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 馃檭

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #8770 (cea12d4) into master (69f287e) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8770   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         169     169           
  Lines       14077   14088   +11     
======================================
+ Hits        13045   13055   +10     
- Misses       1032    1033    +1     

@awaelchli awaelchli added this to the v1.5 milestone Aug 6, 2021
@awaelchli awaelchli added the docs Documentation related label Aug 6, 2021
@awaelchli awaelchli marked this pull request as ready for review August 6, 2021 13:00
@carmocca carmocca added the breaking change Includes a breaking change label Aug 6, 2021
@mergify mergify bot added the ready PRs ready to be merged label Aug 6, 2021
@awaelchli awaelchli enabled auto-merge (squash) August 6, 2021 13:32
@awaelchli awaelchli merged commit e541803 into master Aug 6, 2021
@awaelchli awaelchli deleted the feature/gpus-str branch August 6, 2021 15:41
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change docs Documentation related ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants