-
Notifications
You must be signed in to change notification settings - Fork 80
Fix/large num chunks error #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tchaton
merged 15 commits into
Lightning-AI:main
from
bhimrazy:fix/large-num-chunks-error
Oct 9, 2024
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6c9f6a2
adds close method for tokens loader
bhimrazy 483750f
add close memap for given index
bhimrazy 46461ff
Add test for dataset with large number of chunks
bhimrazy c9fddd5
Add test for generating dataset with large number of chunks
bhimrazy 6332a2e
skip for windows
bhimrazy 4b619d6
Merge branch 'main' into fix/large-num-chunks-error
bhimrazy 6c6d6f2
close mmap before delete
bhimrazy 5e8793b
revert close change: causing segmentation error
bhimrazy 0d2b855
Merge branch 'main' into fix/large-num-chunks-error
bhimrazy a42993d
moved close function to execute only if the current chunk is fully co…
bhimrazy feab694
updated the condition
bhimrazy bddfcdf
removed unused type:ignore
bhimrazy 4f3f394
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9e8d3eb
revert ignore for memoryview
bhimrazy 2f5cfe9
merged changes
bhimrazy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.