Skip to content

Conversation

@otogamer
Copy link
Contributor

@otogamer otogamer commented Aug 6, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #673.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@otogamer otogamer force-pushed the feat/673_add_shuffle_parameter_to_train_test_split branch from 5b622de to c7595b3 Compare August 6, 2025 11:41
@otogamer otogamer changed the title [wip]feat: add shuffle parameter to train_test_split feat: add shuffle parameter to train_test_split Aug 6, 2025
Copy link
Collaborator

@bhimrazy bhimrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀
Appreciate your work, @otogamer — looking forward to more amazing contributions!

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84%. Comparing base (f739826) to head (e67122b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #675   +/-   ##
===================================
- Coverage    84%    84%   -0%     
===================================
  Files        52     52           
  Lines      7143   7144    +1     
===================================
- Hits       5967   5966    -1     
- Misses     1176   1178    +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Borda Borda enabled auto-merge (squash) August 6, 2025 22:14
@Borda Borda requested a review from deependujha August 6, 2025 22:14
@Borda Borda merged commit 9eff5cc into Lightning-AI:main Aug 7, 2025
35 checks passed
@deependujha
Copy link
Collaborator

🎉 Thanks a lot for your contribution, @otogamer! Looking forward to more awesome contributions from you in the future! ⚡️

@bhimrazy
Copy link
Collaborator

bhimrazy commented Aug 7, 2025

Hi @otogamer!,
If you're not already there, pls feel free to join our LightningAI Discord community — we'd love to have you around!

You're welcome to start any discussions or ask questions in the #litdata channel. Looking forward to collaborating more with you! ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add shuffle: bool parameter in train_test_split

5 participants