-
Notifications
You must be signed in to change notification settings - Fork 79
feat: add shuffle parameter to train_test_split #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shuffle parameter to train_test_split #675
Conversation
5b622de to
c7595b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚀
Appreciate your work, @otogamer — looking forward to more amazing contributions!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
===================================
- Coverage 84% 84% -0%
===================================
Files 52 52
Lines 7143 7144 +1
===================================
- Hits 5967 5966 -1
- Misses 1176 1178 +2 🚀 New features to boost your workflow:
|
|
🎉 Thanks a lot for your contribution, @otogamer! Looking forward to more awesome contributions from you in the future! ⚡️ |
|
Hi @otogamer!, You're welcome to start any discussions or ask questions in the |
Before submitting
What does this PR do?
Fixes #673.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃