Skip to content

Don't raise a runtimeError if the downloader doesn't exist. #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Don't raise a runtimeError if the downloader doesn't exist. #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/litdata/streaming/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def download_chunk_from_index(self, chunk_index: int) -> None:
return

if self._downloader is None:
raise RuntimeError("The downloader should be defined.")
return

self._downloader.download_chunk_from_index(chunk_index)

Expand All @@ -101,7 +101,9 @@ def try_decompress(self, local_chunkpath: str) -> None:
with open(local_chunkpath, "rb") as f:
data = f.read()

os.remove(local_chunkpath)
# delete the files only if they were downloaded
if self._downloader is not None:
os.remove(local_chunkpath)

data = self._compressor.decompress(data)

Expand Down