Fix tokens_per_sec
calculation in SpeedMonitor
#415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculations for
tokens_per_sec
(anddevice/tokens_per_sec
) inSpeedMonitor
are wrong, specifically an overestimation by a factor ofwindow_size
(default to 100). To fix, we need to multiplysamples_per_second
by the mean number of tokens per sample (instead of multiplying by the sum of the number of tokens per sample over the lastwindow_size
batches, which is done currently).For comparison, see the reference implementation:
https://github.com/mosaicml/composer/blob/f2a2dc820cb75023b9eb7c46fdfd25273712abd0/composer/callbacks/speed_monitor.py#L279-L284