Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Matthews correlation coefficient when the denominator is 0 #781

Merged
merged 4 commits into from Jan 19, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jan 19, 2022

What does this PR do?

Fixes #779

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jan 19, 2022
@SkafteNicki SkafteNicki added this to the v0.8 milestone Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #781 (bb4e5dd) into master (43a2261) will decrease coverage by 7%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #781    +/-   ##
======================================
- Coverage      95%    88%    -7%     
======================================
  Files         171    171            
  Lines        6883   6888     +5     
======================================
- Hits         6505   6027   -478     
- Misses        378    861   +483     

@Borda Borda modified the milestones: v0.8, v0.7 Jan 19, 2022
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added the ready label Jan 19, 2022
@Borda Borda enabled auto-merge (squash) January 19, 2022 15:23
@Borda Borda disabled auto-merge January 19, 2022 21:34
@Borda Borda merged commit cfe5e87 into master Jan 19, 2022
@Borda Borda deleted the fix/matthews_corrcoef branch January 19, 2022 21:34
Borda pushed a commit that referenced this pull request Jan 19, 2022
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
(cherry picked from commit cfe5e87)
Borda pushed a commit that referenced this pull request Jan 19, 2022
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
(cherry picked from commit cfe5e87)
Borda added a commit that referenced this pull request Jan 19, 2022
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda added a commit that referenced this pull request Jan 19, 2022
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matthews correlation coefficient should return 0 instead of NaN
3 participants