From cbfc68ae8c83b29eb7fa386435ae3b83afb7b166 Mon Sep 17 00:00:00 2001 From: Felipe Whitaker <36129486+felipewhitaker@users.noreply.github.com> Date: Thu, 25 May 2023 11:58:22 -0300 Subject: [PATCH 1/2] Fix doc formatting in `batch_size_finder.py` Fix extra space that broke markdown formatting. --- src/lightning/pytorch/callbacks/batch_size_finder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lightning/pytorch/callbacks/batch_size_finder.py b/src/lightning/pytorch/callbacks/batch_size_finder.py index 93548efb6a059..3e4b5ec0334c1 100644 --- a/src/lightning/pytorch/callbacks/batch_size_finder.py +++ b/src/lightning/pytorch/callbacks/batch_size_finder.py @@ -41,7 +41,7 @@ class BatchSizeFinder(Callback): - ``'power'``: Keep multiplying the batch size by 2, until we get an OOM error. - ``'binsearch'``: Initially keep multiplying by 2 and after encountering an OOM error - do a binary search between the last successful batch size and the batch size that failed. + do a binary search between the last successful batch size and the batch size that failed. steps_per_trial: number of steps to run with a given batch size. Ideally 1 should be enough to test if an OOM error occurs, From e4d391d8f7963855b02818d1429df09802154de9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrian=20W=C3=A4lchli?= Date: Sun, 28 May 2023 18:45:29 -0400 Subject: [PATCH 2/2] Update src/lightning/pytorch/callbacks/batch_size_finder.py --- src/lightning/pytorch/callbacks/batch_size_finder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lightning/pytorch/callbacks/batch_size_finder.py b/src/lightning/pytorch/callbacks/batch_size_finder.py index 3e4b5ec0334c1..02b78a22a5a7f 100644 --- a/src/lightning/pytorch/callbacks/batch_size_finder.py +++ b/src/lightning/pytorch/callbacks/batch_size_finder.py @@ -41,7 +41,7 @@ class BatchSizeFinder(Callback): - ``'power'``: Keep multiplying the batch size by 2, until we get an OOM error. - ``'binsearch'``: Initially keep multiplying by 2 and after encountering an OOM error - do a binary search between the last successful batch size and the batch size that failed. + do a binary search between the last successful batch size and the batch size that failed. steps_per_trial: number of steps to run with a given batch size. Ideally 1 should be enough to test if an OOM error occurs,