From daa675026ee3c2d0b37a779966475bf8af38d3ef Mon Sep 17 00:00:00 2001 From: Nate Raw Date: Mon, 27 Apr 2020 18:08:16 -0600 Subject: [PATCH 1/2] :sparkles: Use store_true for bool args --- pytorch_lightning/trainer/trainer.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pytorch_lightning/trainer/trainer.py b/pytorch_lightning/trainer/trainer.py index 9b27655675dc9..304d50800fcec 100644 --- a/pytorch_lightning/trainer/trainer.py +++ b/pytorch_lightning/trainer/trainer.py @@ -667,6 +667,16 @@ def add_argparse_args(cls, parent_parser: ArgumentParser) -> ArgumentParser: def allowed_type(x): return bool(parsing.strtobool(x)) + # Bool args with default of True parsed as flags not key value pair + if arg_types == (bool,) and arg_default is False: + parser.add_argument( + f'--{arg}', + action='store_true', + dest=arg, + help='autogenerated by pl.Trainer' + ) + continue + if arg == 'gpus': allowed_type = Trainer.allowed_type arg_default = Trainer.arg_default From da303d82a83a5edbbc1b1c6fe9b4f3911b04a31a Mon Sep 17 00:00:00 2001 From: William Falcon Date: Wed, 13 May 2020 18:11:59 -0400 Subject: [PATCH 2/2] debug --- tests/trainer/test_trainer_cli.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/trainer/test_trainer_cli.py b/tests/trainer/test_trainer_cli.py index fdc78d43fe288..9b0e64dfefb7a 100644 --- a/tests/trainer/test_trainer_cli.py +++ b/tests/trainer/test_trainer_cli.py @@ -30,7 +30,7 @@ def test_default_args(tmpdir): @pytest.mark.parametrize('cli_args', [ ['--accumulate_grad_batches=22'], - ['--print_nan_grads=1', '--weights_save_path=./'], + ['--print_nan_grads', '--weights_save_path=./'], [] ]) def test_add_argparse_args_redefined(cli_args):