Skip to content

Conversation

@deependujha
Copy link
Collaborator

@deependujha deependujha commented Nov 21, 2025

What does this PR do?

Fixes #<issue_number>

credits: pr #21369

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21370.org.readthedocs.build/en/21370/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89%. Comparing base (e98df3c) to head (3a32eff).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21370   +/-   ##
=======================================
  Coverage      89%      89%           
=======================================
  Files         269      269           
  Lines       22050    22050           
=======================================
  Hits        19724    19724           
  Misses       2326     2326           

@deependujha
Copy link
Collaborator Author

weird irrelevant errors, but looking into them.

@deependujha deependujha merged commit 8f702b3 into Lightning-AI:master Nov 21, 2025
147 of 211 checks passed
@deependujha deependujha deleted the fix/error-msg branch November 21, 2025 15:18
Iruos8805 pushed a commit to Iruos8805/pytorch-lightning that referenced this pull request Dec 4, 2025
* update

* let's first try with empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants