Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Nov 26, 2020

What does this PR do?

Partial #4859

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #4873 (eaa60ae) into master (442d57f) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4873   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         118     118           
  Lines        9004    8991   -13     
======================================
- Hits         8383    8370   -13     
  Misses        621     621           

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM !

@Borda Borda added this to the 1.1 milestone Nov 26, 2020
@Borda Borda added the ready PRs ready to be merged label Nov 26, 2020
@Borda Borda added 3rd party Related to a 3rd-party priority: 1 Medium priority task labels Nov 26, 2020
@Borda Borda force-pushed the refactor/imports-hydra branch from 83c7c53 to cfe8eaa Compare November 26, 2020 23:02
@Borda Borda merged commit 2176503 into master Nov 27, 2020
@Borda Borda deleted the refactor/imports-hydra branch November 27, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3rd party Related to a 3rd-party priority: 1 Medium priority task ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants