Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Apr 22, 2021

What does this PR do?

fix installation via pip

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working priority: 0 High priority task labels Apr 22, 2021
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #7170 (d85ed91) into master (ef5feac) will decrease coverage by 43%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #7170     +/-   ##
========================================
- Coverage      87%     44%    -43%     
========================================
  Files         197     197             
  Lines       12615   12615             
========================================
- Hits        10997    5553   -5444     
- Misses       1618    7062   +5444     

@lexierule lexierule merged commit f48ac62 into master Apr 22, 2021
@lexierule lexierule deleted the fix/install branch April 22, 2021 20:48
Borda added a commit that referenced this pull request Apr 22, 2021
(cherry picked from commit f48ac62)

# Conflicts:
#	requirements/extra.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: 0 High priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants