From c6df5495a28e33958b968efbc38ebdb9a084a87a Mon Sep 17 00:00:00 2001 From: Nic Eggert Date: Tue, 21 Jan 2020 11:16:21 -0600 Subject: [PATCH 1/2] Fix distributed_backend=None test We now throw a warning instead of an exception. Update test to reflect this. --- tests/test_gpu_models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_gpu_models.py b/tests/test_gpu_models.py index 4608966103c16..ec7f36e838472 100644 --- a/tests/test_gpu_models.py +++ b/tests/test_gpu_models.py @@ -183,7 +183,7 @@ def test_multi_gpu_none_backend(tmpdir): gpus='-1' ) - with pytest.raises(MisconfigurationException): + with pytest.warns(UserWarning): tutils.run_model_test(trainer_options, model) From 4dbde1ee84d624cea12bd3cd5dd63d39ad8eecf9 Mon Sep 17 00:00:00 2001 From: Nic Eggert Date: Tue, 21 Jan 2020 12:00:34 -0600 Subject: [PATCH 2/2] Fix test_tube logger close when debug=True --- pytorch_lightning/logging/test_tube.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pytorch_lightning/logging/test_tube.py b/pytorch_lightning/logging/test_tube.py index ccb50ef3ec700..c1ebc8cad8ff4 100644 --- a/pytorch_lightning/logging/test_tube.py +++ b/pytorch_lightning/logging/test_tube.py @@ -135,8 +135,9 @@ def finalize(self, status): def close(self): # TODO: HACK figure out where this is being set to true self.experiment.debug = self.debug - exp = self.experiment - exp.close() + if not self.debug: + exp = self.experiment + exp.close() @property def rank(self):