Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Jul 28, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

cc: @ethanwharris

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #183 (9da4b08) into main (b51741e) will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #183   +/-   ##
===================================
  Coverage    75%    75%           
===================================
  Files         2      2           
  Lines       370    370           
===================================
  Hits        276    276           
  Misses       94     94           

@krshrimali
Copy link
Contributor Author

@Borda - PTAL. :)

@Borda Borda added the enhancement New feature or request label Aug 15, 2022
@Borda Borda marked this pull request as draft August 20, 2022 10:15
Copy link
Contributor

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebooks need to be added as scripts, not ipython notebooks 🐰

@krshrimali krshrimali force-pushed the flash/tutorials-merge branch from dfe4479 to 603b1c8 Compare August 26, 2022 09:23
@krshrimali krshrimali marked this pull request as ready for review August 26, 2022 09:24
@krshrimali krshrimali force-pushed the flash/tutorials-merge branch from 994147e to 5e41e2f Compare August 26, 2022 09:37
@krshrimali krshrimali requested review from Borda and rohitgr7 August 26, 2022 09:38
@krshrimali krshrimali self-assigned this Aug 26, 2022
@krshrimali krshrimali force-pushed the flash/tutorials-merge branch from 166612f to 3172828 Compare August 26, 2022 10:01
@krshrimali krshrimali force-pushed the flash/tutorials-merge branch from 94be2c2 to 47f32ea Compare August 26, 2022 11:18
@rohitgr7 rohitgr7 added Example Example / Demo / Tutorial PL: Flash labels Aug 29, 2022
@krshrimali krshrimali force-pushed the flash/tutorials-merge branch from f6c72f6 to 2316e74 Compare September 1, 2022 05:08
@rohitgr7 rohitgr7 merged commit bd3a38f into main Sep 2, 2022
@rohitgr7 rohitgr7 deleted the flash/tutorials-merge branch September 2, 2022 09:09
@krshrimali krshrimali mentioned this pull request Nov 4, 2022
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request Example Example / Demo / Tutorial PL: Flash

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants