Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Jul 26, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci/cd label Jul 26, 2021
@Borda Borda marked this pull request as ready for review July 26, 2021 22:29
@Borda Borda force-pushed the main branch 2 times, most recently from d7981ec to 3f9c041 Compare July 27, 2021 19:15
@Borda Borda force-pushed the ci/docformatter branch from 4634e13 to 6fc3dec Compare July 27, 2021 20:40
@Borda
Copy link
Contributor Author

Borda commented Aug 2, 2021

Seems to be using some deprecated API for RL example...

@Borda Borda force-pushed the ci/docformatter branch from 34736d1 to c17f0a8 Compare August 3, 2021 12:35
@pep8speaks
Copy link

pep8speaks commented Aug 3, 2021

Hello @Borda! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 138:121: E501 line too long (134 > 120 characters)
Line 200:121: E501 line too long (132 > 120 characters)

Line 376:121: E501 line too long (122 > 120 characters)

Line 263:121: E501 line too long (130 > 120 characters)
Line 1260:121: E501 line too long (122 > 120 characters)

Line 770:121: E501 line too long (123 > 120 characters)

Comment last updated at 2021-08-03 13:09:30 UTC

@Borda Borda force-pushed the ci/docformatter branch from ffb4b4c to 15e2007 Compare August 3, 2021 12:40
@Borda Borda added the 0:] Ready->Go ready to go/merge label Aug 3, 2021
@Borda Borda force-pushed the ci/docformatter branch from 93b83c2 to b81d716 Compare August 3, 2021 13:09
@Borda Borda enabled auto-merge (squash) August 3, 2021 13:25
@Borda Borda merged commit 974c620 into main Aug 3, 2021
@Borda Borda deleted the ci/docformatter branch August 3, 2021 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

0:] Ready->Go ready to go/merge ci/cd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants